[1.19] Ocean Variant floating in the ocean

pewblaze commented 2 years ago

Hi so the ocean variant is floating (all 3 on the map), also they are pretty near :/ 2022-07-16_18 15 15 2022-07-16_18 15 33

Ive got Terralith. Maybe that why?

PastaLaPasta commented 1 year ago

To add to this issue: the same is consistently happening in oceans generated by Tectonic, but doesn't seem to happen in oceans generated by Oh The Biomes You'll Go. I assume it holds true to any biome mod that makes the oceans deeper.

Eqis-Edu commented 9 months ago

See the below images. Same seed using tectonic (and a lot of other mods, no important for the moment), before and after a small change using datapack (with kubejs). Look how the highlights disappear around ocean cabins (sand in top still visible), but now finally the cabin is grounded.

before

after

The path: kubejs\data\subterrestrial\worldgen\structure\ocean_cabin.json The code: { "type": "minecraft:jigsaw", "biomes": "#subterrestrial:has_structure/ocean_cabin", "max_distance_from_center": 50, "size": 7, "spawn_overrides": {}, "start_height": { "absolute": -1 }, "project_start_to_heightmap": "OCEAN_FLOOR_WG", "start_pool": "subterrestrial:cabin/ocean/base", "step": "underground_structures", "terrain_adaptation": "beard_thin", "use_expansion_hack": false }

(For me, it's funny how the generation is ordered in grid, anyway)

MarioSMB commented 7 months ago

Thanks for the workaround, here's what it would look like in the ocean_cabin.json file if I'm not mistaken:

  "start_height": {
    "absolute": -1
  },
  "project_start_to_heightmap": "OCEAN_FLOOR_WG",

Plus the max_distance_from_center change from 80 to 50 - not sure how that affects it though!

Still occurs in 1.20.1 versions of the mod (2 years later?!).

AlexNijjar / Subterrestrial

[1.19] Ocean Variant floating in the ocean #3