AlexPikalov
commented
7 years ago Makes sense
Open harrydevnull opened 7 years ago
AlexPikalov
commented
7 years ago Makes sense
harrydevnull
commented
7 years ago @alex are planning to work on this if no I ll try to get it done. It would effect all the source files.
AlexPikalov
commented
7 years ago I think it fixed in #62, isn't it?
harrydevnull
commented
7 years ago I just started I might have completed just 10%
On Sun, Feb 5, 2017 at 10:33 AM Alex Pikalov notifications@github.com wrote:
I think it fixed in #62 https://github.com/AlexPikalov/cdrs/pull/62, isn't it?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AlexPikalov/cdrs/issues/57#issuecomment-277527049, or mute the thread https://github.com/notifications/unsubscribe-auth/AM2UnRyqD7Xso8eqPdPAj5x7VSp7N34zks5rZeuygaJpZM4L3EDi .
harrydevnull
commented
7 years ago I just started I might completed 10%
AlexPikalov
commented
7 years ago I see.
AlexPikalov
commented
7 years ago Why wouldn't we create clippy.toml to use consistent rules? https://github.com/Manishearth/rust-clippy#configuration
harrydevnull
commented
7 years ago the problem with that approach is that authors of clippy would be constantly updating the rules. the clippy.toml which we have in our src tree would be outdated very soon or else we need to take pains of manually updating it. hence my take is that no clippy.toml on our src tree and perhaps run cargo clippy as part of travis build.
AlexPikalov
commented
7 years ago @harrydevnull are there any non-fixed clippy issues? For me it seems that everything is fine now.
harrydevnull
commented
7 years ago nope I do see a myriad of issues still.
harrydevnull
commented
7 years ago | arning: 5th binding whose name is just one char --> src/types/data_serialization_types.rs:105:17 | 105 | let e = from_u16_bytes(&bytes[8..10]); | ^ |
|---|
= note: #[warn(many_single_char_names)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#many_single_char_names| warning: 6th binding whose name is just one char --> src/types/data_serialization_types.rs:106:17 | 106 | let f = from_u16_bytes(&bytes[10..12]); | ^ |
|---|
= note: #[warn(many_single_char_names)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#many_single_char_names| warning: 7th binding whose name is just one char --> src/types/data_serialization_types.rs:107:17 | 107 | let g = from_u16_bytes(&bytes[12..14]); | ^ |
|---|
= note: #[warn(many_single_char_names)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#many_single_char_names| warning: 8th binding whose name is just one char --> src/types/data_serialization_types.rs:108:17 | 108 | let h = from_u16_bytes(&bytes[14..16]); | ^ |
|---|
= note: #[warn(many_single_char_names)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#many_single_char_names| warning: this function has too many arguments (8/7) --> src/frame/frame_query.rs:20:5 | 20 | fn new(query: String, | ^ |
|---|
= note: #[warn(too_many_arguments)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#too_many_arguments
| warning: this function has too many arguments (9/7) --> src/frame/frame_query.rs:297:5 | 297 | pub fn new_req_query(query: String, | ^ |
|---|
= note: #[warn(too_many_arguments)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#too_many_arguments| warning: large size difference between variants --> src/frame/frame_response.rs:25:5 | 25 | Result(ResResultBody), | ^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(large_enum_variant)] on by default
help: consider boxing the large fields to reduce the total size of the enum
| Result(Box
warning: you don't need to add & to all patterns
--> src/frame/frame_response.rs:80:17 |
80 | match res { | _____^ starting here... 81 | &ResResultBody::Rows(ref rows) => Some(rows), 82 | _ => None, 83 | } | _____^ ...ending here |
|---|
= note: #[warn(match_ref_pats)] on by default
help: instead of prefixing all patterns with &, you can dereference the expression
| match *res { .. }
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#match_ref_pats
| warning: explicit lifetimes given in parameter types where they could be elided --> src/frame/frame_response.rs:116:5 | 116 | pub fn get_authenticator<'a>(&'a self) -> Option<&'a str> { | _____^ starting here... 117 | match *self { 118 | ResponseBody::Authenticate(ref auth) => Some(auth.data.as_str()), 119 | _ => None, 120 | } 121 | } | _____^ ...ending here |
|---|
= note: #[warn(needless_lifetimes)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes| warning: large size difference between variants --> src/frame/frame_result.rs:70:5 | 70 | Prepared(BodyResResultPrepared), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(large_enum_variant)] on by default
help: consider boxing the large fields to reduce the total size of the enum
| Prepared(Box
| warning: explicit lifetimes given in parameter types where they could be elided --> src/frame/frame_startup.rs:17:5 | 17 | pub fn new<'b>(compression: Option<&'b str>) -> BodyReqStartup<'b> { | _____^ starting here... 18 | let mut map = HashMap::new(); 19 | map.insert(CQL_VERSION, CQL_VERSION_VAL); 20 | if let Some(c) = compression { 21 | map.insert(COMPRESSION, c); 22 | } 23 | BodyReqStartup { map: map } 24 | } | _____^ ...ending here |
|---|
= note: #[warn(needless_lifetimes)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
| warning: this expression borrows a reference that is immediately dereferenced by the compiler --> src/frame/frame_startup.rs:37:29 | 37 | v.extend_from_slice(&self.num().as_slice()); | ^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(needless_borrow)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_borrow
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/frame/frame_startup.rs:38:27 | 38 | for (key, val) in self.map.iter() { | ^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for (key, val) in &self.map { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
error: handle read amount returned or use Read::read_exact instead
--> src/frame/parser.rs:20:5 |
20 | try!(cursor.read(&mut version_bytes)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount = note: this error originates in a macro outside of the current crate
error: handle read amount returned or use Read::read_exact instead
--> src/frame/parser.rs:21:5 |
21 | try!(cursor.read(&mut flag_bytes)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount = note: this error originates in a macro outside of the current crate
error: handle read amount returned or use Read::read_exact instead
--> src/frame/parser.rs:22:5 |
22 | try!(cursor.read(&mut stream_bytes)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount = note: this error originates in a macro outside of the current crate
error: handle read amount returned or use Read::read_exact instead
--> src/frame/parser.rs:23:5 |
23 | try!(cursor.read(&mut opcode_bytes)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount = note: this error originates in a macro outside of the current crate
error: handle read amount returned or use Read::read_exact instead
--> src/frame/parser.rs:24:5 |
24 | try!(cursor.read(&mut length_bytes)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount = note: this error originates in a macro outside of the current crate
| warning: taken reference of right operand --> src/frame/parser.rs:38:48 | 38 | let full_body = if flags.iter().any( | flag | flag == &Flag::Compression) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(op_ref)] on by default help: dereference the left operand instead | let full_body = if flags.iter().any(|flag| *flag == Flag::Compression) { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#op_ref
| warning: taken reference of right operand --> src/frame/parser.rs:47:49 | 47 | let tracing_id = if flags.iter().any( | flag | flag == &Flag::Tracing) { | ^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(op_ref)] on by default help: dereference the left operand instead | let tracing_id = if flags.iter().any(|flag| *flag == Flag::Tracing) { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#op_ref
| warning: taken reference of right operand --> src/frame/parser.rs:60:47 | 60 | let warnings = if flags.iter().any( | flag | flag == &Flag::Warning) { | ^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(op_ref)] on by default help: dereference the left operand instead | let warnings = if flags.iter().any(|flag| *flag == Flag::Warning) { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#op_ref
warning: you don't need to add & to all patterns
--> src/frame/mod.rs:114:9 |
114 | match self { | _____^ starting here... 115 | &Version::Request => 0x04, 116 | &Version::Response => 0x84, 117 | } | _____^ ...ending here |
|---|
= note: #[warn(match_ref_pats)] on by defaulthelp: instead of prefixing all patterns with &, you can dereference the expression
| match *self { .. }
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#match_ref_pats
warning: writing &Vec<_> instead of &[_] involves one more reference and cannot be used with non-Vec-based slices. Consider changing the type to &[...]
--> src/frame/mod.rs:177:34 |
177 | pub fn many_to_cbytes(flags: &Vec |
^^^^^^^^^^ |
|---|
= note: #[warn(ptr_arg)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#ptr_argwarning: you don't need to add & to all patterns
--> src/frame/mod.rs:206:9 |
206 | match self { | _____^ starting here... 207 | &Flag::Compression => 0x01, 208 | &Flag::Tracing => 0x02, 209 | &Flag::CustomPayload => 0x04, 210 | &Flag::Warning => 0x08, 211 | &Flag::Ignore => 0x00, 212 | // assuming that ingoring value whould be other than [0x01, 0x02, 0x04, 0x08] 213 | } | _____^ ...ending here |
|---|
= note: #[warn(match_ref_pats)] on by defaulthelp: instead of prefixing all patterns with &, you can dereference the expression
| match *self { .. }
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#match_ref_pats
warning: you don't need to add & to all patterns
--> src/frame/mod.rs:251:9 |
251 | match self { | ^ |
|---|
= note: #[warn(match_ref_pats)] on by defaulthelp: instead of prefixing all patterns with &, you can dereference the expression
| match *self { .. }
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#match_ref_pats
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/types/data_serialization_types.rs:64:9 |
64 | let ref separator = b'E'; | ^^^^^^^^^^^^^ |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let separator = &b'E'; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 36 | map_as_rust!(K Vec K < K u8 K >, V Vec V < V u8 V >); | ----------------------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 37 | map_as_rust!(K Vec K < K u8 K >, V String); | ------------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 38 | map_as_rust!(K Vec K < K u8 K >, V bool); | ----------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 39 | map_as_rust!(K Vec K < K u8 K >, V i64); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 40 | map_as_rust!(K Vec K < K u8 K >, V i32); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 41 | map_as_rust!(K Vec K < K u8 K >, V i16); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 42 | map_as_rust!(K Vec K < K u8 K >, V i8); | --------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 43 | map_as_rust!(K Vec K < K u8 K >, V f64); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 44 | map_as_rust!(K Vec K < K u8 K >, V f32); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 45 | map_as_rust!(K Vec K < K u8 K >, V IpAddr); | ------------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 46 | map_as_rust!(K Vec K < K u8 K >, V Uuid); | ----------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 47 | map_as_rust!(K Vec K < K u8 K >, V List); | ----------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 48 | map_as_rust!(K Vec K < K u8 K >, V Map); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 49 | map_as_rust!(K Vec K < K u8 K >, V UDT); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 51 | map_as_rust!(K String, V Vec V < V u8 V >); | ------------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 52 | map_as_rust!(K String, V String); | --------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 53 | map_as_rust!(K String, V bool); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 54 | map_as_rust!(K String, V i64); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 55 | map_as_rust!(K String, V i32); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 56 | map_as_rust!(K String, V i16); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 57 | map_as_rust!(K String, V i8); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 58 | map_as_rust!(K String, V f64); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 59 | map_as_rust!(K String, V f32); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 60 | map_as_rust!(K String, V IpAddr); | --------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 61 | map_as_rust!(K String, V Uuid); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 62 | map_as_rust!(K String, V List); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 63 | map_as_rust!(K String, V Map); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 64 | map_as_rust!(K String, V UDT); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 66 | map_as_rust!(K bool, V Vec V < V u8 V >); | ----------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 67 | map_as_rust!(K bool, V String); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 68 | map_as_rust!(K bool, V bool); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 69 | map_as_rust!(K bool, V i64); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 70 | map_as_rust!(K bool, V i32); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 71 | map_as_rust!(K bool, V i16); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 72 | map_as_rust!(K bool, V i8); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 73 | map_as_rust!(K bool, V f64); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 74 | map_as_rust!(K bool, V f32); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 75 | map_as_rust!(K bool, V IpAddr); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 76 | map_as_rust!(K bool, V Uuid); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 77 | map_as_rust!(K bool, V List); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 78 | map_as_rust!(K bool, V Map); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 79 | map_as_rust!(K bool, V UDT); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 81 | map_as_rust!(K i64, V Vec V < V u8 V >); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 82 | map_as_rust!(K i64, V String); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 83 | map_as_rust!(K i64, V bool); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 84 | map_as_rust!(K i64, V i64); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 85 | map_as_rust!(K i64, V i32); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 86 | map_as_rust!(K i64, V i16); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 87 | map_as_rust!(K i64, V i8); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 88 | map_as_rust!(K i64, V f64); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 89 | map_as_rust!(K i64, V f32); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 90 | map_as_rust!(K i64, V IpAddr); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 91 | map_as_rust!(K i64, V Uuid); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 92 | map_as_rust!(K i64, V List); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 93 | map_as_rust!(K i64, V Map); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 94 | map_as_rust!(K i64, V UDT); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 96 | map_as_rust!(K i32, V Vec V < V u8 V >); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 97 | map_as_rust!(K i32, V String); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 98 | map_as_rust!(K i32, V bool); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 99 | map_as_rust!(K i32, V i64); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by default help: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 100 | map_as_rust!(K i32, V i32); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 101 | map_as_rust!(K i32, V i16); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 102 | map_as_rust!(K i32, V i8); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 103 | map_as_rust!(K i32, V f64); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 104 | map_as_rust!(K i32, V f32); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 105 | map_as_rust!(K i32, V IpAddr); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 106 | map_as_rust!(K i32, V Uuid); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 107 | map_as_rust!(K i32, V List); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 108 | map_as_rust!(K i32, V Map); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 109 | map_as_rust!(K i32, V UDT); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 111 | map_as_rust!(K i16, V Vec V < V u8 V >); | ---------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 112 | map_as_rust!(K i16, V String); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 113 | map_as_rust!(K i16, V bool); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 114 | map_as_rust!(K i16, V i64); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 115 | map_as_rust!(K i16, V i32); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 116 | map_as_rust!(K i16, V i16); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 117 | map_as_rust!(K i16, V i8); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 118 | map_as_rust!(K i16, V f64); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 119 | map_as_rust!(K i16, V f32); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 120 | map_as_rust!(K i16, V IpAddr); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 121 | map_as_rust!(K i16, V Uuid); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 122 | map_as_rust!(K i16, V List); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 123 | map_as_rust!(K i16, V Map); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 124 | map_as_rust!(K i16, V UDT); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 126 | map_as_rust!(K i8, V Vec V < V u8 V >); | --------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 127 | map_as_rust!(K i8, V String); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 128 | map_as_rust!(K i8, V bool); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 129 | map_as_rust!(K i8, V i64); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 130 | map_as_rust!(K i8, V i32); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 131 | map_as_rust!(K i8, V i16); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 132 | map_as_rust!(K i8, V i8); | ------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 133 | map_as_rust!(K i8, V f64); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 134 | map_as_rust!(K i8, V f32); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 135 | map_as_rust!(K i8, V IpAddr); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 136 | map_as_rust!(K i8, V Uuid); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 137 | map_as_rust!(K i8, V List); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 138 | map_as_rust!(K i8, V Map); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 139 | map_as_rust!(K i8, V UDT); | -------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 141 | map_as_rust!(K IpAddr, V Vec V < V u8 V >); | ------------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 142 | map_as_rust!(K IpAddr, V String); | --------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 143 | map_as_rust!(K IpAddr, V bool); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 144 | map_as_rust!(K IpAddr, V i64); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 145 | map_as_rust!(K IpAddr, V i32); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 146 | map_as_rust!(K IpAddr, V i16); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 147 | map_as_rust!(K IpAddr, V i8); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 148 | map_as_rust!(K IpAddr, V f64); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 149 | map_as_rust!(K IpAddr, V f32); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 150 | map_as_rust!(K IpAddr, V IpAddr); | --------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 151 | map_as_rust!(K IpAddr, V Uuid); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 152 | map_as_rust!(K IpAddr, V List); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 153 | map_as_rust!(K IpAddr, V Map); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 154 | map_as_rust!(K IpAddr, V UDT); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 156 | map_as_rust!(K Uuid, V Vec V < V u8 V >); | ----------------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 157 | map_as_rust!(K Uuid, V String); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 158 | map_as_rust!(K Uuid, V bool); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 159 | map_as_rust!(K Uuid, V i64); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 160 | map_as_rust!(K Uuid, V i32); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 161 | map_as_rust!(K Uuid, V i16); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 162 | map_as_rust!(K Uuid, V i8); | --------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 163 | map_as_rust!(K Uuid, V f64); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 164 | map_as_rust!(K Uuid, V f32); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 165 | map_as_rust!(K Uuid, V IpAddr); | ------------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 166 | map_as_rust!(K Uuid, V Uuid); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 167 | map_as_rust!(K Uuid, V List); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 168 | map_as_rust!(K Uuid, V Map); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
| warning: it is more idiomatic to loop over references to containers instead of using explicit iteration methods --> src/macros.rs:59:52 | 59 | for &(ref key, ref val) in self.data.iter() { | ^^^^^^^^^^^^^^^^ |
|---|
| ::: src/types/map.rs | 169 | map_as_rust!(K Uuid, V UDT); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(explicit_iter_loop)] on by defaulthelp: to write this more concisely, try | for &(ref key, ref val) in &self.data { = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/types/rows.rs:39:26 |
39 | let ref col_spec = self.metadata.col_specs[i]; | ^^^^^^^^^^^^ |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_spec = &self.metadata.col_specs[i]; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/types/rows.rs:40:26 |
40 | let ref data = self.row_content[i]; | ^^^^^^^^ |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let data = &self.row_content[i]; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/types/rows.rs:50:26 |
50 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 56 | into_rust_by_name!(Row, String); | -------------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 57 | into_rust_by_name!(Row, bool); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 58 | into_rust_by_name!(Row, i64); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 59 | into_rust_by_name!(Row, i32); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 60 | into_rust_by_name!(Row, i16); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 61 | into_rust_by_name!(Row, i8); | ---------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 62 | into_rust_by_name!(Row, f64); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 63 | into_rust_by_name!(Row, f32); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 64 | into_rust_by_name!(Row, IpAddr); | -------------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 65 | into_rust_by_name!(Row, Uuid); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 66 | into_rust_by_name!(Row, List); | ------------------------------ in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 67 | into_rust_by_name!(Row, Map); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 68 | into_rust_by_name!(Row, UDT); | ----------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
warning: ref on an entire let pattern is discouraged, take a reference with & instead
--> src/macros.rs:89:29 |
89 | let ref col_type = col_spec.col_type; | ^^^^^^^^^^^^ |
|---|
| ::: src/types/rows.rs | 69 | into_rust_by_name!(Row, Timespec); | ---------------------------------- in this macro invocation |
|---|
= note: #[warn(toplevel_ref_arg)] on by default help: try | let col_type = &col_spec.col_type; = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg
| warning: explicit lifetimes given in parameter types where they could be elided --> src/types/udt.rs:18:5 | 18 | pub fn new<'a>(data: Vec |
^ |
|---|
= note: #[warn(needless_lifetimes)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes
warning: this let-binding has unit value. Consider omitting let _ =
--> src/types/mod.rs:150:5 |
150 | let _ = bytes.write_i16:: |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(let_unit_value)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_unit_valuewarning: this let-binding has unit value. Consider omitting let _ =
--> src/types/mod.rs:163:5 |
163 | let _ = bytes.write_i32:: |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(let_unit_value)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_unit_valuewarning: this let-binding has unit value. Consider omitting let _ =
--> src/types/mod.rs:176:5 |
176 | let _ = bytes.write_i64:: |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(let_unit_value)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_unit_valuewarning: this let-binding has unit value. Consider omitting let _ =
--> src/types/mod.rs:189:5 |
189 | let _ = bytes.write_u16:: |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(let_unit_value)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_unit_valuewarning: this let-binding has unit value. Consider omitting let _ =
--> src/types/mod.rs:202:5 |
202 | let _ = bytes.write_u32:: |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(let_unit_value)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_unit_valuewarning: this let-binding has unit value. Consider omitting let _ =
--> src/types/mod.rs:215:5 |
215 | let _ = bytes.write_u64:: |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(let_unit_value)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_unit_valuewarning: this let-binding has unit value. Consider omitting let _ =
--> src/types/mod.rs:228:5 |
228 | let _ = bytes.write_f32:: |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(let_unit_value)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_unit_valuewarning: this let-binding has unit value. Consider omitting let _ =
--> src/types/mod.rs:241:5 |
241 | let _ = bytes.write_f64:: |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(let_unit_value)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#let_unit_value| warning: explicit lifetimes given in parameter types where they could be elided --> src/types/mod.rs:257:5 | 257 | pub fn as_str<'a>(&'a self) -> &'a str { | _____^ starting here... 258 | self.string.as_str() 259 | } | _____^ ...ending here |
|---|
= note: #[warn(needless_lifetimes)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes| warning: explicit lifetimes given in parameter types where they could be elided --> src/types/mod.rs:310:5 | 310 | pub fn as_str<'a>(&'a self) -> &'a str { | _____^ starting here... 311 | self.string.as_str() 312 | } | _____^ ...ending here |
|---|
= note: #[warn(needless_lifetimes)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimeserror: handle read amount returned or use Read::read_exact instead
--> src/types/mod.rs:383:9 |
383 | try!(cursor.read(&mut len_bytes)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount
= note: this error originates in a macro outside of the current crateerror: handle written amount returned or use Write::write_all instead
--> src/client.rs:52:9 |
52 | try!(self.transport.write(options_frame.as_slice())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount = note: this error originates in a macro outside of the current crate
error: handle written amount returned or use Write::write_all instead
--> src/client.rs:74:9 |
74 | try!(self.transport.write(startup_frame.as_slice())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount = note: this error originates in a macro outside of the current crate
warning: use of ok_or followed by a function call
--> src/client.rs:95:30 |
95 | let auth_check = self.authenticator | __^ starting here... 96 | .get_cassandra_name() 97 | .ok_or(error::Error::General("No authenticator was provided".to_string())) | __^ ...ending here |
|---|
= note: #[warn(or_fun_call)] on by default help: try this | let auth_check = self.authenticator | .get_cassandra_name().ok_or_else(|| error::Error::General("No authenticator was provided".to_string())) = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#or_fun_call
error: handle written amount returned or use Write::write_all instead
--> src/client.rs:116:13 |
116 | try!(self.transport | _____^ starting here... 117 | .write(Frame::new_req_auth_response(auth_token_bytes) 118 | .into_cbytes() 119 | .as_slice())); | __^ ...ending here |
|---|
= note: #[deny(unused_io_amount)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount
= note: this error originates in a macro outside of the current crate| warning: redundant closure found --> src/client.rs:133:22 | 133 | .map_err( | err | error::Error::Io(err)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(redundant_closure)] on by defaulthelp: remove closure as shown: | .map_err(error::Error::Io) = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#redundant_closure
warning: using clone on a Copy type
--> src/client.rs:147:26 |
147 | let compressor = cdrs.compressor.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[warn(clone_on_copy)] on by defaulthelp: try removing the clone call
| let compressor = cdrs.compressor;
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#clone_on_copy
error: handle written amount returned or use Write::write_all instead
--> src/client.rs:191:9 |
191 | try!(self.cdrs.transport.write(options_frame.as_slice())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount
= note: this error originates in a macro outside of the current crateerror: handle written amount returned or use Write::write_all instead
--> src/client.rs:215:9 |
215 | (self.cdrs.transport.write(options_frame.as_slice()))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amounterror: handle written amount returned or use Write::write_all instead
--> src/client.rs:254:9 |
254 | try!(self.cdrs.transport.write(query_frame.as_slice())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount
= note: this error originates in a macro outside of the current crateerror: handle written amount returned or use Write::write_all instead
--> src/client.rs:275:9 |
275 | try!(self.cdrs.transport.write(query_frame.as_slice())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount
= note: this error originates in a macro outside of the current crate| warning: this lifetime isn't used in the function definition --> src/client.rs:280:23 | 280 | pub fn listen_for<'a>(mut self, | ^^ |
|---|
= note: #[warn(unused_lifetimes)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_lifetimeserror: handle written amount returned or use Write::write_all instead
--> src/client.rs:284:9 |
284 | try!(self.cdrs.transport.write(query_frame.as_slice())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|---|
= note: #[deny(unused_io_amount)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount
= note: this error originates in a macro outside of the current cratewarning: writing &Vec<_> instead of &[_] involves one more reference and cannot be used with non-Vec-based slices. Consider changing the type to &[...]
--> src/cluster.rs:26:41 |
26 | pub fn next<'a, N>(&'a self, nodes: &'a Vec |
^^^^^^^^^^ |
|---|
= note: #[warn(ptr_arg)] on by default = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#ptr_arg
warning: you should consider adding a Default implementation for query::BatchQueryBuilder
--> src/query.rs:215:5 |
215 | pub fn new() -> BatchQueryBuilder { | _____^ starting here... 216 | BatchQueryBuilder { 217 | batch_type: BatchType::Logged, 218 | queries: vec![], 219 | consistency: Consistency::One, 220 | serial_consistency: None, 221 | timestamp: None, 222 | } 223 | } | _____^ ...ending here |
|---|
= note: #[warn(new_without_default)] on by default| help: try this | impl Default for query::BatchQueryBuilder { | fn default() -> Self { | Self::new() | } | } |
|---|
... = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#new_without_default
AlexPikalov
commented
7 years ago holly sht
when we run cargo clippy it will spill out a lot of warnings. we might want to tackle that as we code. cargo clippy cargo fmt as well.