Why are you targeting "netcoreapp2.1" instead of "netstandard2.0"?

AlexPoint / SubtitlesParser

Multi formats subtitles parser in C#

MIT License

134 stars 40 forks source link

Why are you targeting "netcoreapp2.1" instead of "netstandard2.0"? #14

Closed NikolayIT closed 5 years ago

NikolayIT commented 5 years ago

I've managed to build the project successfully targeting .NET Standard.

SubtitlesParser.1.4.7.nupkg.zip

Why do you target .NET Core App 2.1? It is more limiting.

AlexPoint commented 5 years ago

I haven't touched this library for quite some time now so I don't remember if there was a reason for using .NET Core. If you manage to compile and run the tests with .NET Standard - indeed, I don't see any reason why .NET Standard wouldn't be enough - you can a pull request and I'll accept the changes.

Anduin2017 commented 5 years ago

It was me who upgraded this project from .NET Framework to .NET Core. I didn't consider that you may use it in Xamarin or other areas.