Please remove all Console.WriteLine calls in the parsers

AlexPoint / SubtitlesParser

Multi formats subtitles parser in C#

MIT License

134 stars 40 forks source link

Please remove all Console.WriteLine calls in the parsers #15

Closed NikolayIT closed 5 years ago

NikolayIT commented 5 years ago

Console.WriteLine is not the appropriate way to log debug information (example: https://github.com/AlexPoint/SubtitlesParser/blob/master/SubtitlesParser/Classes/Parsers/MicroDvdParser.cs#L77)

Not only it brings noise to the Console applicaitons, it also crashes when this code is ran in Windows Service environment.

AlexPoint commented 5 years ago

You're right, this "Console.WriteLine" statement is probably a remnant of my debugging. It would be great if you can a pull request fixing this issue.