Generic refactoring - Githubissues

AlexPresso / VideoStation-FFMPEG-Patcher

Patcher to enable DTS, EAC3 and TrueHD transcoding support to Synology VideoStation (from DSM 6.2 to DSM 7.0 and above ; ffmpeg4, 5, 6, 7 ready)

1.06k stars 102 forks source link

Generic refactoring #109

Closed AlexPresso closed 1 year ago

AlexPresso commented 1 year ago

This PR aims to help the VideoStation's patch and MediaServer's patch to work together (i.e. you want to patch VideoStation + MediaServer).

Changes:

Make CodecPack (Advanced Media Extensions) patch standalone : CodecPack is not anymore relying on VideoStation's patched files to work. It's safer this way, as VideoStation can be removed without breaking CodecPack features.
CodecPack patched ffmpeg files (ffmpeg33, ffmpeg41 and/or ffmpeg27) are now trying with CodecPack default ffmpeg files before trying to use SynoCommunity's ffmpeg. Again, it's safer for other applications also relying on CodecPack's ffmpeg to work.
Group gstreamer patched libraries and plugins into same directory to make it easier and safer to remove.
Make the wrappers work in a more generic way
Code cleaning

AlexPresso commented 1 year ago

Hey there,

If some people wants to test this PR, please follow these instructions:

uninstall the patch : curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -a unpatch
install the new patch curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/generic_refactor/patcher.sh | bash -s -- -a patch -b generic_refactor

Please inform me of any issue you could have

AlexPresso commented 1 year ago

Tested OK on my DS218Play

AlexPresso commented 1 year ago

Hi @Fabian1601 ; @djhibee and @ner00 Sorry to ping you, but if you mind testing this new patcher using the previous comment procedure, it would be highly appreciated

Fabian1601 commented 1 year ago

Hello Alex,

im already on it but as soon as it restarts in script videostation it reindexes all files. It i start in the meantime the install script and it restarts videostation again it trashes all my database. But the Problem has always been there and nothing to do with your script. It just takes a Moment 😉

AlexPresso commented 1 year ago

Yeah it also happens to me sometimes ahah, I have to reindex everything, it's quite annoying, but I guess Synology don't want to work on fixing that

Thank you very much :)

Fabian1601 commented 1 year ago

So script ran smoothly and no problems so far. Playback is fine and i have a file in offline transcoding but it still needs about 20min to finish 👍

update: Transcoding finished without any issue 👌