search

AlexPresso / VideoStation-FFMPEG-Patcher

Patcher to enable DTS, EAC3 and TrueHD transcoding support to Synology VideoStation (from DSM 6.2 to DSM 7.0 and above ; ffmpeg4, 5, 6, 7 ready)
1.06k stars 102 forks source link

hevc main 10 offline transcode to high fails #16

Closed Fabian1601 closed 2 years ago

Fabian1601 commented 3 years ago

hello alex,

when i try to transcode hevc main 10 offline the conversion always fails and it creates me a 0mb mp4 file. in the "offline transcoding list" it says "done". but if i choose "medium" as resolution it creates the correct file. are you already aware of the error?

greetings

I have attached the log file from the conversion of the film in high and medium resolution ffmpeg.log gs

AlexPresso commented 3 years ago

Hello Fabian,

Yes, I'm aware of an issue related to HEVC transcoding (even real-time transcoding), it's not directly related to the patcher (it's related to the wrapper), but I'm planning to fix it when I have time.

Could you put the content of your log file in a gist instead of a file please ?

Greetings

Fabian1601 commented 3 years ago

hello alex,

here as gist.

https://gist.github.com/Fabian1601/e24a8695891a1d695dde9e90862227ed

greetings

AlexPresso commented 3 years ago

Hi,

Thank you for the logs, it will help me fix the wrapper and make it capable of wrapping Advanced Media Extensions. I'll need some time to do it, but until then, I'll keep the following issue opened and mention it in a future pull request.

Greetings

pacifikballa commented 2 years ago

AlexPresso,

Here is the link. Its good for a day.

http://gofile.me/6OElE/a0qvKsHty

AlexPresso commented 2 years ago

Thank you for the link, you said earlier:

Maybe I can upload my patched file or wrapper so u can compare? I've never done that before though so wouldn't know where to start.

Do you mean you edited the wrapper downloaded by the script (/var/packages/VideoStation/target/bin/ffmpeg) ?

pacifikballa commented 2 years ago

Thank you for the link, you said earlier:

Maybe I can upload my patched file or wrapper so u can compare? I've never done that before though so wouldn't know where to start.

Do you mean you edited the wrapper downloaded by the script (/var/packages/VideoStation/target/bin/ffmpeg) ?

I didn't edit anything. Just figured since it is all working for me, somehow mine may differ from yours.

AlexPresso commented 2 years ago

Oh okay, I understand No the patch procedure is the same for everyone, my script is downloading the wrapper directly from source, without editing it ;)

pacifikballa commented 2 years ago

Oh okay, I understand No the patch procedure is the same for everyone, my script is downloading the wrapper directly from source, without editing it ;)

Ok gotcha.....well, i'm not sure what i did, but everything i have is working...i tested it all. HEVC with DTS/Atmos, EAC3, AAC, h264/h265...u name it, i got it, and it all works. How did that download go? Did the movie play for u?

AlexPresso commented 2 years ago

I was able to download the file but unfortunately it didn't play on my DS218Play, I'm still trying to understand why it fails

pacifikballa commented 2 years ago

All I remember doing was uninstalling Video Station, AME, and FFMPEG.

Then based on my logs, I installed them back in the following order:

  1. Install FFMPEG
  2. Install AME
  3. Install Video Station
  4. Stop Video Station, Start Video Station.

Then I tested all the different video files I had that had different audio codecs and they all work.

Worth a shot to start clean and install in the order I did. It may or may not work for you, but it’s worth a shot.

On Thu, Mar 10, 2022 at 5:14 PM AlexPresso @.***> wrote:

I was able to download the file but unfortunately it didn't play on my DS218Play, I'm still trying to understand why it fails

— Reply to this email directly, view it on GitHub https://github.com/AlexPresso/VideoStation-FFMPEG-Patcher/issues/16#issuecomment-1064673687, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATFED3U5THK7EOGQFVOEKLTU7KM5XANCNFSM5H2LSK3Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

findstevehere commented 2 years ago

thanks guys for all the work on this stuff to make VS much much more usable, but wondering what should simple people do like myself do.....who arent that savvy with command line or terminal commands and there's two duelling people now with two different methods of patching, with the seemingly more complicated, nebulas also seems to work better with H265, while Alex's, which I successfully did last time before the recent VS update because it's much simpler, but H265 doesnt seem to work consistently. I really wish someone would do a video or something, because these instructions are rarely complete....never gives you step by step instructions on every step and then others chime in about installing Putty or something and then just paste or use this command when, blah blah blah....and someone like pacific gives links to other files and edits or whatever.....it's seriously nuts for regular people like myself, not so command savvy trying to wade through all this and months and months, if not years of comments and conversations and trying to get a handle on the best route to go. someone needs to simplify or collate all this for the ordinary folks to be able to decipher and implement. thanks

AlexPresso commented 2 years ago

@findstevehere I think you sent this message to the wrong chan ;) this is the issue page of my patcher, not the gist

ja-vivanco commented 2 years ago

In my case it fails when transcoding H265 in high quality AND using hardware transcoding. If you disable hardware transcoding it works with high and medium quality.

I have patched synocodec tool with https://github.com/dmc31a42/synocodectool-patch

Fabian1601 commented 2 years ago

Can you maybe explain how you did that? I would much rather use Alex's script, but your idea seems to be a good temporary solution Am 13.04.2022, 20:21:33, "ja-vivanco" @.> schrieb: > > > In my case it fails when transcoding H265 in high quality AND using hardware transcoding. If you disable hardware transcoding it works with high and medium quality. > > > > I have patched synocodec tool with https://github.com/dmc31a42/synocodectool-patch > > > > — > Reply to this email directly, view it on GitHub (https://github.com/AlexPresso/VideoStation-FFMPEG-Patcher/issues/16#issuecomment-1098350516), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AO2TODTNWGT7ZMGHEVTTW33VE4GCNANCNFSM5H2LSK3Q). > You are receiving this because you authored the thread.Message ID: @.> > >

ja-vivanco commented 2 years ago

You have to use Alex's script anyway, because even if hevec transcoding don't fully work, it still some quite common audio codecs that Videso Station native ffmepeg do not support, so my setup.

1) Install Video Station 2) Install community ffmpeg 1) use synocodectool patch and apply the path to the all of 3 suggested location. 2) use Alex Video Station patch

Option 1 Now, if you really need Hevc transcoding at high quality go to Video Station -> configuration -> Advanced and disable transcoding. Obvisly you CPU needs to be good enough to process the transcoding without hardware acceleration

Option 2 Just select medium quality in the configuration of the app, DS video for your phone or TV.

findstevehere commented 2 years ago

You have to use Alex's script anyway, because even if hevec transcoding don't fully work, it still some quite common audio codecs that Videso Station native ffmepeg do not support, so my setup.

  1. Install Video Station
  2. Install community ffmpeg
  3. use synocodectool patch and apply the path to the all of 3 suggested location.
  4. use Alex Video Station patch

Option 1 Now, if you really need Hevc transcoding at high quality go to Video Station -> configuration -> Advanced and disable transcoding. Obvisly you CPU needs to be good enough to process the transcoding without hardware acceleration

Option 2 Just select medium quality in the configuration of the app, DS video for your phone or TV.

findstevehere commented 2 years ago

huh? Alex patch gets error - "error" install ffmpeg"
what is synocodectool patch and 3 locations?

AlexPresso commented 2 years ago

@findstevehere could you run the following steps and send the output please:

AlexPresso commented 2 years ago

@findstevehere did you have the time to check my previous comment ?

findstevehere commented 2 years ago

hey thanks, will try later today and post.

ja-vivanco commented 2 years ago

hey thanks, will try later today and post.

huh? Alex patch gets error - "error" install ffmpeg" what is synocodectool patch and 3 locations?

Have you installed synocummunity ffmpeg before applying AlexPresso patch?

AlexPresso commented 2 years ago

@Fabian1601 Did you have the time to check if the problem is fixed by the CodecPack's patch ?

Fabian1601 commented 2 years ago

Hello alex,

Give me a moment and I will test it. Unfortunately, it takes me a few hours to re-index the videos after reinstalling VS (it also checks all the files again when it gets the database). I will report as soon as it is ready

Fabian1601 commented 2 years ago

So, I reset everything to original and ran your script over it. Playback works great. But offline transcoding aborts every time with "the network connection is unstable...".

Fabian1601 commented 2 years ago

here the ffmpeg.log

https://gist.github.com/Fabian1601/ceda916cf53711f9a351fc9f1fe46bf4

AlexPresso commented 2 years ago

Moved to #36

findstevehere commented 2 years ago

@findstevehere could you run the following steps and send the output please:

  • Connect to your NAS using SSH (admin user required) (help)
  • Use the command sudo -i to switch to root user
  • ls -al /var/packages

I get no such file or directory

MacBook-Air:~ root# ls -al /var/packages ls: /var/packages: No such file or directory MacBook-Air:~ root#

findstevehere commented 2 years ago

@findstevehere could you run the following steps and send the output please:

  • Connect to your NAS using SSH (admin user required) (help)
  • Use the command sudo -i to switch to root user
  • ls -al /var/packages

I get no such file or directory

MacBook-Air:~ root# ls -al /var/packages ls: /var/packages: No such file or directory MacBook-Air:~ root#

also not showing any ffmpeg log files at all or directory

MacBook-Air:tmp root# ls -al | grep ffmpeg MacBook-Air:tmp root# tail -200 ffmpeg.log tail: ffmpeg.log: No such file or directory MacBook-Air:tmp root#

AlexPresso commented 2 years ago

Please follow meticulously every step from this link: https://kb.synology.com/en-global/DSM/tutorial/How_to_login_to_DSM_with_root_permission_via_SSH_Telnet

The reason it's not working is because you're executing the patch on your Mac (like you are trying to patch your mac). But it's not what you want to do. You want to patch your Synology NAS, and to do that, you need to connect to your NAS (through SSH) before executing the command to run the patch. If you don't follow the above steps, the patch won't work at all.