[BUG] offline transcoding fails after latest script update

AlexPresso / VideoStation-FFMPEG-Patcher

Patcher to enable DTS, EAC3 and TrueHD transcoding support to Synology VideoStation (from DSM 6.2 to DSM 7.0 and above ; ffmpeg4, 5, 6, 7 ready)

1.06k stars 102 forks source link

[BUG] offline transcoding fails after latest script update #90

Closed Fabian1601 closed 1 year ago

Fabian1601 commented 1 year ago

Hello Alex, after the last script update 2 weeks ago every movie is played but the offline transcoding is not possible. I tried it with ffmpeg v4 and v6, it comes the same error. also in your error report script

"[scale_vaapi @ 0x5647b9fb2c80] [Eval @ 0x7ffea2727d70] Undefined constant or missing '(' in 'format=nv12|vaapi' Last message repeated 1 times [scale_vaapi @ 0x5647b9fb2c80] Error when evaluating the expression 'format=nv12|vaapi'."

my system:

ds1520+
dsm 7.2-64570 update 3
vs 3.1.0-3153
ams 3.1.0-3005
ffmpeg 6.0-2
ffmpeg 4.4.4-49

https://gist.github.com/Fabian1601/0dff6091cfe03781f579efeedd79737b

AlexPresso commented 1 year ago

Hello Fabian,

Thanks for your issue, yes you are right, I'll fix this today or tomorrow, sorry for the bug

AlexPresso commented 1 year ago

Hello @Fabian1601

I made a fix attempt in the linked PR, could you try to use the following procedure to test it please:

uninstall the patch : curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -a unpatch
install the new patch curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/fix_scale/patcher.sh | bash -s -- -a patch -b fix_scale

If you still have an issue please run the issue-report tool and post the result here again

Fabian1601 commented 1 year ago

Hello Alex,

now everything is working like a charm, thanks :-)

AlexPresso commented 1 year ago

Thanks to you, I'm glad everything working again :)