AlexR32 / Bracket

User Interface Library For Roblox
10 stars 7 forks source link

V3.3 Colorpicker error's in console #1

Closed NTFSquad closed 3 months ago

NTFSquad commented 4 months ago

Line 1447 fixed by just tostringing the bool:

PaletteAsset.Alpha.Value.Text = tostring(Value[4])

AlexR32 commented 4 months ago

Value[4] is not the bool its actually alpha value of HSV you should not use bool on value[4], if you need rainbow mode set value[5] to true

NTFSquad commented 4 months ago

Ma bad i switched to v3.4 now. by the way question is there a way to use the section's name instead not the toggle's in the keybind list?

AlexR32 commented 4 months ago

is there a way to use the section's name instead not the toggle's in the keybind list?

No, and i dont see any reason why you need that but i might add custom name option for keybind list

NTFSquad commented 4 months ago

That would be great thank you, the reason i requested that is because currently i use Section for every feature and the toggle for them is named Enabled.

AlexR32 commented 4 months ago

Added Keybind.CustomName in https://github.com/AlexR32/Bracket/commit/34b645e5769e31702b9b81c8f73a6dcd9ada5b16

NTFSquad commented 4 months ago

Hello AlexR32, i would like to ask some questions about V3.4.

Firstly is the tab button is there a way to make like in V3? here's what i mean

image

Secondly do you plan to add keybind types?

Toggle / Hold

Lastly how's your day?

Hope it's great.

AlexR32 commented 4 months ago

Secondly do you plan to add keybind types?

I don't know how to implement this, I find it hard to understand how to do this, should there be a button to toggle this state? Or should just right-clicking on the key text toggle the state? Then if it is a click, how to inform the user about the state change, should it be a tool tip or additional text?

Firstly is the tab button is there a way to make like in V3? here's what i mean

At this time this style of tab buttons is not available but I can make it

NTFSquad commented 4 months ago

Secondly do you plan to add keybind types?

Honestly same but by my opinion you should right-click on the key text toggle to change the state.

and the informing part either a tool tip OR highlighting the current state here's what i mean

image

Firstly is the tab button is there a way to make like in V3? here's what i mean

I will be waiting!

Edit

From the image the always state shouldn't be an option just the keybind being unbinded should be the state of always

NTFSquad commented 4 months ago

Window.Blur Bug

Basicly using Window.Blur at the startup will not work but later on will (like using a toggle after)

local Bracket = loadstring(game:HttpGet("https://raw.githubusercontent.com/AlexR32/Bracket/main/BracketV34.lua"))()

local Window = Bracket:Window({Blur = true}) do
    print(Window.Blur)
end

image

Edit

I haven't tested on other version's only V3.4

AlexR32 commented 3 months ago

Everything you suggested and reported is added/fixed in new commit: https://github.com/AlexR32/Bracket/commit/ad2b7dfc00f6f2905722c694606986220ca3122f

Thanks for your contributions Edit: make sure open new issue for other things because this issue topic becomes complete mess