AlexRaubach / MetaWing

Analysis tool for X-Wing Second Edition tournament data
https://meta.listfortress.com/
MIT License
2 stars 3 forks source link

Bad XWS names causes orphan pilot entries and missing Pilot images #29

Closed AlexRaubach closed 3 years ago

AlexRaubach commented 3 years ago

Sometimes pilots are given the wrong xws name in xwd2. Metawing's xwd autoupdater runs and generates a Pilot with the invalid xws name. Then the name is changed in xwd2 and the updater creates a second entry for that pilot because it can't update the old pilot. This leaves us with a second empty entry for that pilot.

This isn't a big problem, these empty pilots don't have games associated with them and they're only linked on the ships index page and the page for the specific ship they pilot. I only noticed the issue because MW couldn't find 4 pilot cards because card images are given the xws name of the pilot so a bad xws name means a 404 error.

I don't think there is anything to do but manually check for missing images and then confirm that the problem isn't a duplicate pilot.

You can delete them by opening a rails console in prod and running Pilot.find(id_here).destroy One pilot had some child entries so I had to first run Pilot.find(id_here).pilot_slots.each { |x| x.destroy }