search

AlexSa1000 / MysticalAgriculture-Refabricated

Fabric port of Mystical Agriculture
MIT License
10 stars 11 forks source link

Update to latest versions of fabric #36

Open KirboSoftware opened 6 months ago

KirboSoftware commented 6 months ago

This PR updates the code base of mystical agriculture to the newest versions of Fabric and Porting Lib.

This PR is required next to #5 of Cucumber Refabricated

What does it contain?

What does it fix?

version mismatch of mods that use newer versions of porting lib on 1.20.1 see #4 of cucumber

Testing

I've made this fix both on cucumber refabricated and mystical agriculture refabricated so it would require these changes to test.

but I ran this with: image and never received a issue again. After implementing these fixes.

If you have questions or comments about this. Please put them in this PR 👍 or message me on discord.

KirboSoftware commented 6 months ago

also fixes #35

Reixeen commented 6 months ago

Impressive work, but how does this turn into a working jar file?

I've done everything I can think of but I am getting nothing in game.

Still better than all the crashes with the non-forked versions.

Poopooracoocoo commented 6 months ago

Could you also add cucumber and forgeconfigapiport to the depends section of the fabric.mod.json?

KirboSoftware commented 6 months ago

Could you also add cucumber and forgeconfigapiport to the depends section of the fabric.mod.json?

I will add that and @Reixeen if needed, I can make the jar's available per releases tab on both forks of mine. Just so it's playable for people who do want it.

Reixeen commented 6 months ago

Yes that would be extremely useful thank you.

I tried to look up a tutorial for this, but so far I am unsuccessful.

Poopooracoocoo commented 6 months ago

@Reixeen Download KirboSoftware's branch as a zip, extract the zip to a folder, open a terminal window in the folder, run ./gradlew build. Do the same thing with KirboSoftware's Cucumber fork.

KirboSoftware commented 6 months ago

You can also see the branches and check the releases tab on my forks. It's more a temp solution I've put there for people to play with and if there are fixes needed, you can just post issues there. (1.20.1 for now, but if others are desired. Say so)

see:

keep in mind, these are temporary and will be removed if @AlexSa1000 desires so

Reixeen commented 6 months ago

@Poopooracoocoo i tried that but i must have been missing something in my java env so ./gradlew build kept failing

@KirboSoftware thank you so much :)))) you are a legend

KirboSoftware commented 6 months ago

No worries 👍 I also plan to release soon:tm: mystical agriditions fabricated along these updated forks if Alex gives permission for that (I have contacted Alex and await response there. Untill then, I might just update the forks I already have. Will see)

jfoppe commented 1 day ago

@KirboSoftware did you keep it up to date? Because there are some bug with die Guide Book