AlexSheer / phpbb3.2-Knowledge-Base

Knowledge Base
GNU General Public License v2.0
1 stars 5 forks source link

Update FRENCH translation + fix style. #20

Closed Galixte closed 7 years ago

Galixte commented 7 years ago

Hi @AlexSheer,

could you merge this, please?

AlexSheer commented 7 years ago

I'm renamed some files from old stupid error

Conflicting files language/fr/info_acp_knowlegebase.php language/fr/knowlegebase_lng.php So, please recheck it

Galixte commented 7 years ago

ok i’ll re-submit this PR.

Galixte commented 7 years ago

https://github.com/AlexSheer/phpbb3.2-Knowledge-Base/pull/24

Galixte commented 7 years ago

@AlexSheer i see your renaming changes but there is an other one, here: https://github.com/AlexSheer/phpbb3.2-Knowledge-Base/blob/master/migrations/version_1_0_0.php#L311

Sheer/knowlegebase\ should be Sheer/knowledgebase\, no?

AlexSheer commented 7 years ago

No. It's for converting from old version for 3.1.x.

Galixte commented 7 years ago

ok, thanks.