search

AlexShkarin / pyLabLib

Python package for device control and experiment automation
http://pylablib.readthedocs.io
GNU General Public License v3.0
139 stars 33 forks source link

Thorlabs Kinesis enable_channel() Function #10

Open Em607867 opened 2 years ago

Em607867 commented 2 years ago

Alexey,

Just wanted to bring something I noticed to your attention.

The _enablechannel() function which enables or disables a given channel returns an error message which I'm guessing you're aware of based on the comment '# seems not to work for most devices when tested' below;

image

However, this actually works as intended on the K-cube (KBD 101) controller (i.e it actually disables or enables the channel) even though this error message pops up. Wonder if there is a feedback on the backend (recv_comm to check whether channel is enabled or not) that is causing this error.

On my end this isn't a problem as I can ignore the error message but thought it's something worth sharing.

Thanks again for your great work.

Best Regards, Manny

AlexShkarin commented 2 years ago

Dear Manny,

Thanks for pointing it out! It looks like I used self.query instead of self.send_comm inside the _enable_channel method, so the code expects a reply which never comes. It will be fixed in the new release.

There is, however, another error which I have seen occasionally (e.g., with a TDC101 device), where _is_channel_enabled would always return False, although _enable_channel still functions. Could you please check if it works with your controller?

Sincerely,

Alexey.

Em607867 commented 2 years ago

Hi Alexey,

I have also previously noticed the issue you described with is_channel_enabled function. I get an error message below even though the channel is enabled:

image