AlexTelon / FlexiCharge-Org

FlexiCharge Organization repo
3 stars 45 forks source link

added my name #68

Closed GabrielAdward closed 1 year ago

AlexTelon commented 1 year ago

Hi @GabrielAdward and @Afram7. Note that both of you are making a lot of whitespace changes to your PR's. #68 and #70

It makes it slightly harder for me to review and it makes it so that depending on what order I make the PR's the other one of you might have to redo your formatting changes.

This is why in general the goal is to create minimal PR's and take potential merge conflicts into account.

The most efficient way to work would be if nobody improved on the formatting until the end when we can fix it once and of all. If indeed that is even something we want to do.

I personally would not bother with it at all (unless with an automated tool) since its a never ending issue of fixing the widths when new names are added/removed/modified.

I personally wont approve a PR unless its minimal. But someone else might.