AlexTelon / FlexiCharge-Org

FlexiCharge Organization repo
3 stars 45 forks source link

Enforce rules as described by GitPraxis.md #79

Closed AlexTelon closed 1 year ago

AlexTelon commented 1 year ago

(btw we should add a version to the GitPraxis.md file in case we ever make "breaking changes", it would be useful to know which version I am applying my changed based on at a glance without having to be a detective and look at dates)

Leon created https://github.com/AlexTelon/FlexiExample/ and then transfered ownership to me. It has 2 rulesets that I need to apply for all repos since Im the owner Im the only one who can do that.

I need to enforce this in the following repos

Skipping these as they are not used?

Skipping this since we dont build anything from this repo, its only for documentation.

(todo we should probablye update the GitPraxis.md document to note that the Org repo is exempt)

AlexTelon commented 1 year ago

@ecle20yy @ljungqvistaxel to enforce this in your BMS repo I changed master to main.

Tell me if you notice any issues with how I applied this to your repo. I will wait a little bit before I apply the rules to other repos. Like for a day at most. But would want some feedback if things works as expected before I do this manually on all other repos.

Also I have not added @ellencarlsson our build master to have any exemptions. I did not find a way to add a individual directly. Only roles and roles seem to only be possible to manage if one has a organization. See #73.

Would this cause issues? Every process must not be enforced by tooling. We can have a policy that she is the only one who can accept PR's to main even if technically all collaborators in the repo can do so.

AlexTelon commented 1 year ago

Multiple teams have branches with the wrong names. Im not sure if we should ask them to fix their branch names first then I can apply these changes? Because if I apply these changes first then the Android team might not be able to rename Dev to dev for instance. I would then have to do so manually.

ecle20yy commented 1 year ago

I will tell my squad to begin working with the reporitory to see if they encounter any issues.

ecle20yy commented 1 year ago

I have tested the new rules. See this issue for what I tried. Did not try to push to main though, but other than that the rules seems to work.

foal20ym commented 1 year ago

Multiple teams have branches with the wrong names. Im not sure if we should ask them to fix their branch names first then I can apply these changes? Because if I apply these changes first then the Android team might not be able to rename Dev to dev for instance. I would then have to do so manually.

We have now renamed the Dev branch to 'dev'. I give you a green light to apply the changes! 👍

AlexTelon commented 1 year ago

Great. I will apply these rules on the remaining repos tomorrow then

AlexTelon commented 1 year ago

Have applied to all teams now.