search

AlexTorresDev / custom-electron-titlebar

Custom electon title bar inpire on VS Code title bar
MIT License
866 stars 148 forks source link

this is no work in mac os 10.15.7 #145

Closed samping closed 2 years ago

samping commented 3 years ago

Desktop (please complete the following information):

can not work in mac

tarik56 commented 3 years ago

Hello, try using Electron version "^9.0.0" in your package.json, idk why but all versions above seem to not support the custom title bar.

ericblade commented 3 years ago

works fine up to 12 with me

Araxeus commented 3 years ago

Can confirm that it doesn't work with atleast some versions of macOS and electron 11

jharrels commented 3 years ago

I can also confirm Electron 12.0.1 and MacOS 10.15.7 does not show the traffic signals for me. Making a frameless window without the custom titlebar package is also not showing the traffic lights like it used to, so some behavior may have changed elsewhere.

jharrels commented 3 years ago

I see what's going on here. You must add both titleBarStyle and frame BrowserWindow options in order for the Mac traffic lights to appear. titleBarStyle has no effect on Windows/Linux, but on the Mac, it causes the traffic lights to show.

titleBarStyle: "hiddenInset", frame: false,

Araxeus commented 3 years ago

@jharrels what about the custom menu? does it work for you on mac?

jharrels commented 3 years ago

@Araxeus No, the custom menu does not show on the Mac. Works fine on Windows and Linux using the same code.

mac windows

wizzle-discord commented 3 years ago

Hey guys, any update on this? Just trying to get it working on Catalina. I was on electron 11.0.2 but have tried 9.0.0 and no luck. Works fine on windows. I've followed the example code as well. Has anyone got it working?

jharrels commented 3 years ago

@wizzle-discord I finally gave up on it and moved to completely menu-less app, still using electron-custom-titlebar for the titlebar, however.

Capture

AlexTorresDev commented 2 years ago

@Araxeus No, the custom menu does not show on the Mac. Works fine on Windows and Linux using the same code.

mac windows

The custom menu is not displayed on Mac because on Mac the menu already appears in the upper left, next to the apple logo. This project is made to make that happen.

ArsenicBismuth commented 1 year ago

@AlexTorresDev Is it possible to override this behavior for macOS and keep showing the HTML-based menu? Imperfection is fine since I can fine-tune the layout in CSS.

Motive: I use this library to work around the fact that macOS hides app menu if we disable dock icon.