AlexTorresDev / custom-electron-titlebar

Custom electon title bar inpire on VS Code title bar
MIT License
868 stars 149 forks source link

Doesn't work with electron v16.0.0 #165

Closed Akyllyde closed 2 years ago

Akyllyde commented 2 years ago

Describe the bug Executing npm install custom-electron-titlebar shows this error

Could not resolve dependency:
peer electron@"^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0" from custom-electron-titlebar@3.2.9 
node_modules/custom-electron-titlebar
custom-electron-titlebar@"*" from the root project

Desktop:

bierzorutas commented 2 years ago

For me is not working, but not errors are present so maybe that´s the reason... thanks

ericblade commented 2 years ago

I'm not sure this can be fixed without major surgery, a few electron versions ago deprecated and probably removed in the interim, some of the architecture here. :|

bierzorutas commented 2 years ago

Hi @ericblade I give a quick update, at least in my case: electron + electron-builder + Angular 10 After many hours, I made it work using the last-version branch: https://github.com/AlexTorresSk/custom-electron-titlebar/tree/v3.2.10 Following the steps given in the README.md is not enough, I need in my case for example to call Remote.initialize() in main thread, and also in my specific case, as I have a splash loading screen, I need to specify to which window is applied, using Remote.enable(win.webContents).

Another issue I had was when going to FullScreen (F11 in windows), for me was not working, it hidde the min/max/close button but the topBar was pressent, so I need to add my own code to dispose() title bar and recreate in the preload.js file...

In MacOS is not working, but this I am not sure if is expected or not..

DerGoogler commented 2 years ago

use -f

Akyllyde commented 2 years ago

use -f @DerGoogler forcing an install isn't good practice but I did that, and still doesn't work. I have made my own custom titlebar using IPCommunication

froschi123 commented 2 years ago

Will that issue be fixed in the next version?

AlexTorresDev commented 2 years ago

Will that issue be fixed in the next version?

In 4.0.0 was fixed