v4.1.0

[Araxeus]

Lots of fixes and improvements, its too late at night right to detail everything now but in short:

• Fix submenu's [1]

• Fix Checkboxes/Radio buttons [1]

• Added radio icons (fix #149) [1]

• Allow changing svg icon color

• Added refreshMenu() function (automatically pulls new menu from Menu.getApplicationMenu())

• Reduce 99% of the boilerplate from the last release (fix #174)

• menuOptions.menu can be set to null to not use any menu or undefined (can just omit the property) to automatically get it from Menu.getApplicationMenu())

• Fix controls button svg out of position when browserWindow height is low

and probably more, will try to find time to write more details about this pr /+ add docs later this week

Notes:

• example menu was changed because default electron menu isn't enough for testing - need to test that custom menu with submenu+checkbox+radio+separator+role works

• [1] easy way to experience the submenu/radioButton fixes: try loading the example menu in v4.0.1 - it wont work at all

• All fixes and improvements were also tested on https://github.com/th-ch/youtube-music/pull/596

[AlexTorresDev]

This is fantastic. But remember that the changes go through the develop branch first. Please do the PR to the develop branch to avoid conflicts.

[Araxeus]

Roger that, will add empty checkbox icon, lint, add docs, explanations for changes

And will also make the target branch to the correct dev branch

[AlexTorresDev]

@Araxeus I merged this into develop, since I had done some previous commits it looks like a weird merge, but everything is merged and up to date.

On the other hand, I can create the documentation for the new implementation on the Wiki, and thus you save doing this. Similarly, I will add a contributing readme to avoid PR in master. Sorry for the disturbances

[Araxeus]

Ok great this needs alot of wiki changes, would be nice if you could make it a PR (maybe wiki pages could also be in the repo as md files somewhere) so that I can also have a look and confirm that all the changes are present

should includes:

• { setupTitlebar, attachTitlebarToWindow }
• titlebar.refreshMenu()
• options.svgColor
• and how to use/not use a menu ( in options.menu null=no menu , undefined=Electron's menu`)

(also need to add to wiki alot of things that already existed in readme.md before - see #168)

[Araxeus]

@AlexTorresSk any eta on when a new version will be published?