search

AlexTorresDev / custom-electron-titlebar

Custom electon title bar inpire on VS Code title bar
MIT License
866 stars 148 forks source link

Link to titlebar documentation is dead #232

Closed crystalfp closed 1 year ago

crystalfp commented 1 year ago

Describe the bug The link at the end of Get started page points nowhere.

To Reproduce Steps to reproduce the behavior:

  1. Go to Get started page
  2. Click on 'Titlebar Options' at the bottom of the page
  3. See 404 error

Expected behavior Find documentation on how to use the package

Desktop (please complete the following information):

mikeseese commented 1 year ago

The same happens for the link at the bottom of the Titlebar Options page to go back to the getting-started. They seem to be going to ./<page> which is resolving them to /<lang>/docs/<current-page>/<next-page>

The issue seems to be rooted at https://github.com/AlexTorresDev/cet-docs/blob/1a1ec1e143f53e96bb127007a49a5640f8f8d6d1/src/components/Navigation.astro#L22 and https://github.com/AlexTorresDev/cet-docs/blob/1a1ec1e143f53e96bb127007a49a5640f8f8d6d1/src/components/Navigation.astro#L41

and should probably be something like 

          href={`../${previous.slug.split("/")[1]}`}
AlexTorresDev commented 1 year ago

The documentation has been moved to the wiki so that it can be updated through the same repository.

📝 Wiki