AlexTrotsenko / j2v8-debugger

This project is an add-on for the excellent J2V8 Project. It allows users to debug JS running in V8 using Chrome DevTools. Uses Stetho for communication with Chrome DevTools.
88 stars 24 forks source link

Add support for Debugger.setScriptSource #14

Closed Dimezis closed 2 years ago

Dimezis commented 3 years ago

Allows editing JS code from Chrome dev tools

AlexTrotsenko commented 3 years ago

@Dimezis thanks for contributing this change, it loos great!

I will add some cosmetic changes, merge and release the new version of the lib.

Just to double-check - looks like scriptUriToIdMap is basically mirrored version of the v8ScriptMap, right ?

Dimezis commented 3 years ago

Great, thanks!

Just to double-check - looks like scriptUriToIdMap is basically mirrored version of the v8ScriptMap, right

Yup, it was needed to correctly replace the URI coming from Chrome Dev Tools with a real ID registered in the V8 engine