search

AlexTrotsenko / j2v8-debugger

This project is an add-on for the excellent J2V8 Project. It allows users to debug JS running in V8 using Chrome DevTools. Uses Stetho for communication with Chrome DevTools.
88 stars 24 forks source link

Use latest chrome, CDT cannot be opened correctly. #16

Closed yinyinnie closed 1 month ago

yinyinnie commented 2 years ago

pls reference this issue: https://github.com/facebook/stetho/issues/696

AlexTrotsenko commented 2 years ago

@yinyinnie thanks for highlighting this issue. May i possibly ask you what do you mean saying "reference this issue"? Do you mean adding mentioning of this issue in the readme or ?

I don't see any fix nor work-around beside using the old version of Chrome, etc.

yinyinnie commented 2 years ago

I mean that this problem is caused by https://github.com/facebook/stetho/issues/696.

yinyinnie commented 2 years ago

And I have a question: if we want to fix this issue, should we modify the code of facebook/stetho?

AlexTrotsenko commented 1 year ago

@yinyinnie I believe that doing changes on the facebook/stetho side could be a good idea - if you have a capacity - feel free to proceed with it. Alternatively, as mentioned in that issue description, using the old Chrome version could be a work-around to run j2v8-debugger with stetho.

yinyinnie commented 11 months ago

@AlexTrotsenko i have fixed this issue, pls help merge this PR #18 thks.