search

AlexTrotsenko / j2v8-debugger

This project is an add-on for the excellent J2V8 Project. It allows users to debug JS running in V8 using Chrome DevTools. Uses Stetho for communication with Chrome DevTools.
88 stars 24 forks source link

Fix for setting breakpoints while debugger is paused. #9

Closed jamie-houston closed 4 years ago

jamie-houston commented 4 years ago

Changed add breakpoint function to execute instead of submit v8Executor call. If debugger was running it never submitted. Since the result doesn't rely on the the call we don't need to submit, we can just execute the v8Exector.

The newly added breakpoint will not be hit until the script is executed again, but it will no longer kill DevTools when a breakpoint is set while debugging. Might be able to have it hit the breakpoint as well, but this is much better than before.

jamie-houston commented 4 years ago

@AlexTrotsenko this fixes the last issue https://github.com/AlexTrotsenko/j2v8-debugger/issues/2. The other issues are resolved with the previous PRs.

AlexTrotsenko commented 4 years ago

@jamie-houston thanks for your excellent work overall and submitting this MR particularly, I am planning to have a look on it by Monday.

Meanwhile I did a very quick look through and I have noticed, that there is a minor typo in changelog - it says 0.2.1 instead of 0.2.2.

If you would change it yourself - can you possibly have such changes done as a separate commit "Release 0.2.2" etc. ? You can have a look at this commit for an example. I feels it might help to browse the history later.

If you are not planing to touch it - then I can force push the changes myself before the merge.

jamie-houston commented 4 years ago

@AlexTrotsenko you can force push the changes. Next time I'll put the version changes in a a separate PR. Thanks!