search

AlexVerrico / octoprint-stats

Stats for your octoprint instance. Mirrored from https://github.com/amsbr/OctoPrint-Stats originally
14 stars 8 forks source link

Remove description on manual py2 install #16

Closed snecklifter closed 3 years ago

AlexVerrico commented 3 years ago

Hi @snecklifter While I appreciate the contribution, I fail to see the value that this PR adds to the repo / plugin. Cheers, Alex.

snecklifter commented 3 years ago

@AlexVerrico would have thought it is self-explanatory? In #12 you mention your frustration at people manually installing with py2 so this is just a minor readme update to reflect that py2 is no longer supported.

It was a trivial PR I did when I was following that PR due to another issue I'm having. Feel free not to make the change. I really don't care enough to go into a long discussion about updating a readme.

AlexVerrico commented 3 years ago

Hi @snecklifter I added the Python 2 install section of the README after that PR, as although I'm not going to provide updates for Python 2, I'm not going to force people over to Python 3, hence I left an option for Python 2 installation. Again, I do appreciate the contribution, but I won't be merging this PR. Cheers, Alex.