search

AlexVerrico / octoprint-stats

Stats for your octoprint instance. Mirrored from https://github.com/amsbr/OctoPrint-Stats originally
14 stars 8 forks source link

Stops cancelled prints being double counted #5

Closed Menace-Dennis closed 3 years ago

Menace-Dennis commented 3 years ago

When a print is cancelled, in stats this is counted as both "Cancelled" and "Failed". It should be one or the other really. Personally, in my fork, I chose to save the "Failed" status for prints that stopped because of errors. I then moved the "Error" category to the connection stack as this included errors that didn't also stop a print. This way the "Complete" + "Cancelled" + "Failed" is the same height as started. Completely up to you whether you implement this.

AlexVerrico commented 3 years ago

Hi @Menace-Dennis I'm happy to merge these changes, just wanted to check what version(s) of Python and Octoprint you have tested it with? Cheers, Alex.

Menace-Dennis commented 3 years ago

Created new pull request so closing this one