AlexW00 / obsidian-note-linker

🔗 Automatically link your Obsidian notes.
MIT License
195 stars 9 forks source link

Could only link 1 notes... bug. #22

Closed ccchan234 closed 1 year ago

ccchan234 commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

note contain 3 name of notes, suggested 3 links, but only linked 1 at last.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

in a new note, type in 3 already existing notes' name.

scan note, shows 3 but could only link 1.

Expected behavior A clear and concise description of what you expected to happen.

it showed 3, but after ticking, only show link 1.

Screenshots If applicable, add screenshots to help explain your problem.

note: image

plugin:

3 ticks checked, bottom shows only 1.

image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

ccchan234 commented 1 year ago

even i made a new vault,

install almost no other plugin,

it's same result:

image

ccchan234 commented 1 year ago

even i made a new vault,

install almost no other plugin,

it's same result:

image

tested, even just have note linker as the only plugin, same result

cypherm0nk commented 1 year ago

I am also having the same problem

Synteh commented 1 year ago

Same problem here. Definitely a bug and not an individual issue.

ccchan234 commented 1 year ago

most FOSS = abandoned ware, orphans... produced by producers for fun, without considerations of future

Synteh commented 1 year ago

most FOSS = abandoned ware, orphans... produced by producers for fun, without considerations of future

Quite sad, since the idea is brilliant and no other plugin does what this does so well (in idea). I have some coding knowledge, but not enough that in less than 30 minutes I could figure out what the problem seems to stem from. More time spent on it would not be worth it in my case, since in less then an hour, I used the current solution (of clicking them one by one) and I got what I wanted.

schobernoise commented 1 year ago

Same Problem here! What a Pity, it would have been the perfect plugin for me...

ShortTimeNoSee commented 1 year ago

Indeed, same problem. Here's to hoping.

ccchan234 commented 1 year ago

most FOSS = abandoned ware, orphans... produced by producers for fun, without considerations of future

Quite sad, since the idea is brilliant and no other plugin does what this does so well (in idea). I have some coding knowledge, but not enough that in less than 30 minutes I could figure out what the problem seems to stem from. More time spent on it would not be worth it in my case, since in less then an hour, I used the current solution (of clicking them one by one) and I got what I wanted.

try gpt4.

i just used gpt4 to enhanced launchQ, a life changer for me i think.

i don't need this plugin anymore, otherwise i could help

ccchan234 commented 1 year ago

i dont need this, because it links ALL keywords?

but now i agree /w obsidian's authors, that such linking is meaningless.

you should only link those thare are MEANINGFUL

so you could tag them on the Rt hand side one by one manually

schobernoise commented 1 year ago

Well, this might be true, but it still is the case that you can choose which links will be created by ticking them... which saves a lot of time for linking obvious keywords. I have a lot of articles saved, which could be linked easily to important topics with this plugin.

ccchan234 commented 1 year ago

Well, this might be true, but it still is the case that you can choose which links will be created by ticking them... which saves a lot of time for linking obvious keywords. I have a lot of articles saved, which could be linked easily to important topics with this plugin.

i think obsidian itself allow you to tag on the Right hand side. when it found unlinked but likely related thing, there is a "not linked" button there, you click it and they become linked.

AlexW00 commented 1 year ago

This should be fixed in the latest release. It was a problem with useMemo and React. Hope it works for everyone now.

schobernoise commented 1 year ago

Thank you, this works now for single notes, and also for a smaller amount of notes. There is a problem though with linking a bigger amount (+2K). The plugin freezes and becomes unresponsive. Maybe a problem with loading all the links into memory?

AlexW00 commented 1 year ago

Thank you, this works now for single notes, and also for a smaller amount of notes. There is a problem though with linking a bigger amount (+2K). The plugin freezes and becomes unresponsive. Maybe a problem with loading all the links into memory?

Yeah, probably due to the removal of useMemo (which helps avoiding unnecessary re renders). If I have time I'll look into it again to improve performance.

schobernoise commented 1 year ago

Thank you very much, this is highly appreciated!