search

AlexWebLab / bootstrap-5-wordpress-navbar-walker

Bootstrap 5 WordPress navbar walker menu.
https://github.com/AlexWebLab/bootstrap-5-wordpress-navbar-walker
MIT License
250 stars 107 forks source link

Validation Error #3

Closed asifpix closed 3 years ago

asifpix commented 3 years ago

Hi,

First of all thanks for the nice walker. I have used it in my WordPress theme and when I went to validate my site it gets validation error duplicate attributes. That is why it I came here to let you know.

When your menu depth is higher than 0 then it will get validation error.

Best Regards

AlexWebLab commented 3 years ago

Hello there, Thank you for your feedback. I never heard of this kind of error. Can you help me to reproduce it? If you tell me the exact steps to get it then I can fix it. If you have an online example it would be even better. Thanks.

asifpix commented 3 years ago

Hi Alex,

First of create a menu which has sub menu item or dropdown item in Appearance > Menus By creating a dropdown menu using your walker it will output two class. One is class = "dropdown-item" and another one is class = "nav-link" But it should be output in a single class like this class = "dropdown-item nav-link" Screenshot_1

I have fixed the error though. If you wish I can send a pull request of this fix.

Best Regards Asif

AlexWebLab commented 3 years ago

Oh yeah I can see that now. I have an idea on how to fix it but I'm curious to see also your solution. Feel free to send a pull request. Thanks.

asifpix commented 3 years ago

Thanks Alex, I have sent a pull request. Best Regards

AlexWebLab commented 3 years ago

Thank you Asif, I've merged your pull request and fixed some class name conflicts.

asifpix commented 3 years ago

You are most welcome Alex. Stay fine.