Alexander-Lancellott / MH-HP-Overlay-For-3DS-Emulator

A simple open-source HP overlay that I've developed for MH 3G/3U, MH 4/U/G, and MH X/GEN/XX in Python.
https://ko-fi.com/alexander_lancellott
GNU General Public License v3.0
3 stars 0 forks source link

Crashing #5

Closed ZxCFss closed 1 week ago

ZxCFss commented 1 week ago

When loading from save state while the program is running causing Citra to crash.

cody-png commented 1 week ago

Same thing with abandoning a quest. Didn't know the overlay was causing my save state crashes, so I just abandoned a quest without the overlay and it didn't crash, but when overlay is on it'll crash.

Alexander-Lancellott commented 1 week ago

Does this crash occur only with version 1.1.0, or also with previous versions ?

cody-png commented 1 week ago

It's been occurring since 1.0.3 for me for both cases. Edit: To clarify, I have only used 1.0.3 and 1.1.0 and the crash for both abandoning a quest and loading a save state persists in both.

Alexander-Lancellott commented 1 week ago

Thank you for the information. I have been able to replicate the bug and will start investigating, although I'm not sure if I'll be able to fix it soon.

Alexander-Lancellott commented 1 week ago

Hi, the issue with state loading should have been resolved with release v1.1.1. However, I haven’t been able to replicate or experience the same issue when abandoning a quest, so if v1.1.1 doesn’t fix that problem, I suggest you try adjusting the hp_update_time option (found in config.ini) to values higher than 0.5.

cody-png commented 1 week ago

1.1.1 fixes the load state crash as well as crashing after abandoning quests. No need to change HP Update Time.

Alexander-Lancellott commented 1 week ago

That sounds good, thanks.

ZxCFss commented 6 days ago

Thank you! Sorry I didn't check Github at all lol, only found out now from checking my email.