search

Alexander-Miller / treemacs

GNU General Public License v3.0
2.1k stars 154 forks source link

Add project: Error running timer 'pulse-tick' #249

Closed TheKashe closed 6 years ago

TheKashe commented 6 years ago

When I try to add a project using C-p a, I get:

Error running timer 'pulse-tick': (args-out-of-range -1 -1)

Alexander-Miller commented 6 years ago
myrgy commented 6 years ago

Hi there,

I dunno if it's related, but I got this error:

Debugger entered--Lisp error: (args-out-of-range 638 27182)
  count-lines(27182 638)
  treemacs--maybe-recenter()
  treemacs--follow()
  apply(treemacs--follow nil)
  timer-event-handler([t 0 0 200000 nil treemacs--follow nil idle 0])

Thanks a lot!

Alexander-Miller commented 6 years ago

The base error is the same, but they're thrown in completely separate parts of the code, though I guess there's a chance both are caused by the same underlying problem.

Is this issue reproducible somehow, does it happen consistently?

myrgy commented 6 years ago

I use spacemacs with treemacs, STR: open some project, then switch file using SPS p f, switch to not opened file. Error will appear.

Alexander-Miller commented 6 years ago

Do you use emacs as a systemd service, or a server with emacsclient or something similar?

myrgy commented 6 years ago

I just ran emacs binary. emacs server is disabled.

Alexander-Miller commented 6 years ago

Ah, I've found the issue. Long story short I should've used with-selected-window instead of with-current-buffer. Patch will come soon, at least the follow error will be solved then.

Alexander-Miller commented 6 years ago

@myrgy Patch is on master now, that should solve your problem.

@is-r-not-j I don't know if my changes will help you as well. If not I will need more information to proceed.

myrgy commented 6 years ago

@Alexander-Miller , I don't observe issue any more. Thanks a lot!

TheKashe commented 6 years ago

Hi, the issue remains for me. There's nothing special about my config that I could think of, pretty vanilla emacs with just a few packages.

I did disable png images though, might be related!

Stack trace is:

Debugger entered--Lisp error: (args-out-of-range -1 -1) get-text-property(-1 display) treemacs--pulse-png-advice() apply(treemacs--pulse-png-advice nil) pulse-lighten-highlight() pulse-tick((23418 42407 775818 999999)) apply(pulse-tick (23418 42407 775818 999999)) timer-event-handler([t 23418 42407 505823 0.03 pulse-tick ((23418 42407 775818 999999)) nil 999999])

Edit: yep, enabling png images did allow me to add a project!

On a related note, would be nice to be able to add projects through cusotmisation variables to have them in init file

Alexander-Miller commented 6 years ago

yep, enabling png images did allow me to add a project!

Good. If I know it I can fix it.

would be nice to be able to add projects through cusotmisation variables to have them in init file

That is not the current course, though a better interface is on the way as part of the larger workspace initiative. You can basically achieve something similar by customizing treemacs-persist-file. I've recently switched the persist format to be a small subset of org-mode. So you can just point the persist file to an org file next to your init.

I also plan to introduce a command that will pop up and org mode buffer with the current workspace state to allow quick edits.

I will however take a small break here because I want to kick off https://github.com/Alexander-Miller/treemacs/issues/263 with @yyoncho.

Alexander-Miller commented 6 years ago

@is-r-not-j I've just pushed a couple of patches, your issues should be fixed now.

Alexander-Miller commented 6 years ago

I assume all is done here.