search

Alexander-Miller / treemacs

GNU General Public License v3.0
2.08k stars 152 forks source link

treemacs-perspective bug #916

Open jkdufair opened 2 years ago

jkdufair commented 2 years ago

Hi - I noticed with the change mentioned here, that treemacs-perspective broke. I believe the call in treemacs-perspective--ensure-workspace-exists to treemacs--select-workspace-by-name should use treemacs--find-workspace-by-name now. At least that seems to have fixed it here. I'm not set up to make a PR right now so I hope this is sufficient. Thank you!

jkdufair commented 2 years ago

Forgot to leave a link to the relevant commit. It's this one: https://github.com/Alexander-Miller/treemacs/commit/04cbbd93e63405278db470b1d0f7db3eae8725ed

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity.

sevillaarvin commented 2 years ago

Hello, can you elaborate on what needs to be changed? Based on the commit you linked, the previous line was:

(workspace (or (treemacs--select-workspace-by-name perspective-name)

Which was changed to:

(workspace (or (treemacs--find-workspace-by-name perspective-name)

I tried changing it back to treemacs--select-workspace-by-name perspective-name but I don't think it had any effect.

I'm a beginner trying to get the treemacs-perspective to work but so far I don't think it's working. I'm not exactly sure what the integration does as well.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity.