Open ghost opened 4 years ago
1) Minor https://github.com/AlexanderAndr/Alexander_BSU/blob/8322380a947a560c8a70d3fd8e5823b481651473/Twitter(html).html#L2 lang attribute is required 2) https://github.com/AlexanderAndr/Alexander_BSU/blob/8322380a947a560c8a70d3fd8e5823b481651473/Twitter(html).html#L7 background is not valid attribute (use css) 3) https://github.com/AlexanderAndr/Alexander_BSU/blob/8322380a947a560c8a70d3fd8e5823b481651473/Twitter(html).html#L9 Use css to style text in h1, b - bold is additional spatial attribute for "rich text" that out of direct control. 4) Major Semantic missed no header / main / footer 5) https://github.com/AlexanderAndr/Alexander_BSU/blob/8322380a947a560c8a70d3fd8e5823b481651473/Twitter(html).html#L23 and a lot of more occurrences ('div1', 'div2') Use kebab-case for class names, and use clear and readable names Clean-code acceptance criteria failed. 6) Is not responsive css: 7) title tag is metadata and can not have styles 8) Minor Do not copy-paste prefixes (-moz-, -webkit-, etc.) you not need them here 9) sort tag is not exist or approved
Total mark is 5 (with - basically)
1) Minor https://github.com/AlexanderAndr/Alexander_BSU/blob/8322380a947a560c8a70d3fd8e5823b481651473/Twitter(html).html#L2 lang attribute is required 2) https://github.com/AlexanderAndr/Alexander_BSU/blob/8322380a947a560c8a70d3fd8e5823b481651473/Twitter(html).html#L7 background is not valid attribute (use css) 3) https://github.com/AlexanderAndr/Alexander_BSU/blob/8322380a947a560c8a70d3fd8e5823b481651473/Twitter(html).html#L9 Use css to style text in h1, b - bold is additional spatial attribute for "rich text" that out of direct control. 4) Major Semantic missed no header / main / footer 5) https://github.com/AlexanderAndr/Alexander_BSU/blob/8322380a947a560c8a70d3fd8e5823b481651473/Twitter(html).html#L23 and a lot of more occurrences ('div1', 'div2') Use kebab-case for class names, and use clear and readable names Clean-code acceptance criteria failed. 6) Is not responsive css: 7) title tag is metadata and can not have styles 8) Minor Do not copy-paste prefixes (-moz-, -webkit-, etc.) you not need them here 9) sort tag is not exist or approved
Total mark is 5 (with - basically)