AlexanderBabel / homebridge-broadlink-rm

[This fork supports TV accessories] Broadlink RM Mini and Pro plugin for homebridge: https://github.com/nfarina/homebridge
Apache License 2.0
46 stars 11 forks source link

Air con temperature is set always to defaultTemperature #60

Closed stefantitu closed 4 years ago

stefantitu commented 4 years ago

While I try change the temperature of the air con, the return temperature is always the default one, for cooling and heating. A part of the config file is also copied below.

[12/14/2019, 1:14:48 PM] [Broadlink RM] Air Conditioner setTargetTemperature: 32 [12/14/2019, 1:14:48 PM] [Broadlink RM] Air Conditioner No heat HEX code found for 32 [12/14/2019, 1:14:48 PM] [Broadlink RM] Air Conditioner Update to default temperature (30) [12/14/2019, 1:14:48 PM] [Broadlink RM] Air Conditioner sendHex (192.168.0.115; 42:f7:c8:48:61:62) 2600d800000126941336133712121213121212121238123811381337123712131237123812121238131113111312121212121337123713371311121312121213111312121213111312121213121212121212133712381212121212131212131112131212121212131212121213121212121212131212123812121212121311131212121312121212121311131212121312121212121312121212121312121212123812371312121212121213121213111213121212121213123713121237121312121212121312121238123712381237121312371238121212000d05 [12/14/2019, 1:14:48 PM] [Broadlink RM] Air Conditioner getTargetTemperature: 30 [12/14/2019, 1:14:48 PM] [Broadlink RM] Air Conditioner sentTemperature (30) [12/14/2019, 1:14:49 PM] [Broadlink RM] Air Conditioner setCurrentHeatingCoolingState: 1 [12/14/2019, 1:14:49 PM] [Broadlink RM] Air Conditioner setCurrentHeatingCoolingState: already 1 (no data sent - B)

{ "name": "Air Conditioner", "type": "air-conditioner", "defaultCoolTemperature": 20, "defaultHeatTemperature": 30, "pseudoDeviceTemperature": 22, "heatTemperature": 26, "data": { "off": "hexcode", .................................. "temperature28": { "data": "hexcode", "pseudo-mode": "heat" }, "temperature29": { "data": "hexcode", "pseudo-mode": "heat" }, "temperature30": { "data": "hexcode", "pseudo-mode": "heat" }, "temperature31": { "data": "hexcode", "pseudo-mode": "heat" }, "temperature32": { "data": "hexcode", "pseudo-mode": "heat" } } }

kiwi-cam commented 4 years ago

I've had a quick look at this and nothing is jumping out at me. It's clearly not finding a hexcode for heat32, but for some reason it then fails to get the hexcode for temperature32. I'll need to do some testing at home and see if I can recreate this... but it's unlikely that will happen this year sorry.

stefantitu commented 4 years ago

I found out what was the issue. I replaced “temperature” with “heat” or “cool”, and it works. For example temperature30 is now heat30 and so on.

kiwi-cam commented 4 years ago

Thanks for the update @stefantitu. That's more of a workaround than a fix since it should fall back to temperatureX hexcodes if the modeX codes aren't setup. I've just updated this in github with a fix I've tested out. Could you try installing from git to test this for me? Just run npm install -g git+https://github.com/AlexanderBabel/homebridge-broadlink-rm and it'll install over the top. Then just restart homebridge to run the changes. If you're happy I'll get it updated in NPM so everyone installs v4.0.5.

EDIT - actually it's on npmjs now :-) Let me know if you have any issues.

stefantitu commented 4 years ago

Ok. Thank you.