search

AlexanderBuzz / xrpl-php

A PHP library to interact with the XRP Ledger (XRPL) blockchain
ISC License
5 stars 3 forks source link

Bug: Seed to Account #16

Closed zgrguric closed 1 year ago

zgrguric commented 1 year ago

Just used rippled wallet_propose to generate account: Seed: ssNYVX6qYzKNu48FBBs4LuvgfivEJ Account: rNWgYiADKLCJDfZX3oAdPcsRHe9vtJdCVD key_type: secp256k1

image

Using this I get wrong address, I think key type should be considered automatically?

$wallet = Wallet::fromSeed('ssNYVX6qYzKNu48FBBs4LuvgfivEJ');
echo 'Returned address: '.$wallet->getClassicAddress();
//Returned address:  rGkCCVz64f1UYVGK6Qpzd9e8J898Wtr9LY
zgrguric commented 1 year ago

I think it should throw error or atleast autodetect algo?

Not sure how xrpl.js do this.

AlexanderBuzz commented 1 year ago

It should, I'll have a look what is the issue here

AlexanderBuzz commented 1 year ago

@zgrguric So autodetection is implemented with test, release is v0.7.5. Thanks for battle testing this!