search

AlexanderFabisch / gmr

Gaussian Mixture Regression
https://alexanderfabisch.github.io/gmr/
BSD 3-Clause "New" or "Revised" License
168 stars 49 forks source link

Fixed __init__.py to work with Python 3 and migrated to setuptools #1

Closed jfsantos closed 9 years ago

jfsantos commented 9 years ago

__init__.py had an issue which caused a crash when trying to import the model in Python 3. I also migrated setup.py to use setuptools, which has improved functionality (like being able to link your working repository as a package using setup.py develop).

landscape-bot commented 9 years ago

Code Health Repository health decreased by 0.59% when pulling 6749ccc on jfsantos:master into d476ae6 on AlexanderFabisch:master.

AlexanderFabisch commented 9 years ago

Hi, thanks for your contribution. What is the reason for copying the version string to the setup.py? Is this really required?

jfsantos commented 9 years ago

That's actually not necessary and I'm reverting it right now. I updated the minor Python version for Python 3 as well.

landscape-bot commented 9 years ago

Code Health Repository health decreased by 0.59% when pulling d3cd72b on jfsantos:master into d476ae6 on AlexanderFabisch:master.

AlexanderFabisch commented 9 years ago

Thank you. The pull request has been merged.