search

AlexanderFabisch / gmr

Gaussian Mixture Regression
https://alexanderfabisch.github.io/gmr/
BSD 3-Clause "New" or "Revised" License
172 stars 49 forks source link

JOSS paper authorship #37

Closed AlexanderFabisch closed 3 years ago

AlexanderFabisch commented 3 years ago

I recently submitted a paper to the journal of open source software. Submitted papers are typically tightly coupled with Zenodo releases. Here is the latest release of GMR: https://zenodo.org/record/4889867 and here is the paper review issue: https://github.com/openjournals/joss-reviews/issues/3054

In addition to myself, Zenodo also lists you, @jfsantos and @mralbu, as authors. That is why I would have to agree with you both on whether you want to become author of the JOSS paper as well. Both author lists should be as similar as possible.

@jfsantos The amount of lines of code that you contributed and that survived in the latest version of gmr is 8 so that I suggest that it would not make sense to include you as an author if that is OK. Do you want to stay author of the Zenodo release or should I remove your name here? I wouldn't have any issue with any of the two options.

@mralbu You contributed the sklearn interface and I adopted your idea for doing faster batch mean predictions. So I would ask you whether you want to become co-author of the paper. Have a look at the latest article proof here: https://github.com/openjournals/joss-reviews/issues/3054#issuecomment-852008730 . The current state of the review is that both reviewers accepted the paper and we are currently only discussing the authorship details.

jfsantos commented 3 years ago

Hi Alexander,

the changes I did were minimal and setup-related, and do not warrant authorship for sure. Feel free to remove my name from the list of authors.

AlexanderFabisch commented 3 years ago

Thanks for the feedback @jfsantos !

AlexanderFabisch commented 3 years ago

I read that as I should remove you as author from the Zenodo release and from the JOSS paper. If that is a misinterpretation, please let be know.

mralbu commented 3 years ago

Hi @AlexanderFabisch, Thanks for the invitation. My contributions were not very significative, and I didn't contribute with the paper, so it would be ok not to be included as author as well.

AlexanderFabisch commented 3 years ago

@mralbu Thanks for your feedback.

Also thank you both for your contributions, which helped to improve the library. :)