[BUG] - DELETE namespace clashing on Windows - Githubissues

AlexanderJDupree / Bridges

HTTP/S Server and Library for C++

MIT License

2 stars 0 forks source link

[BUG] - DELETE namespace clashing on Windows #13

Open AlexanderJDupree opened 4 years ago

AlexanderJDupree commented 4 years ago

Describe the Bug Unfortunately, DELETE is a macro on Windows and is defined in winnt.h. Since it's a macro the compiler does not care about it the constant value being scoped within the Bridges namespace which is causing compilation issues.

We need to investigate possible solutions.

undef the macro? Probably will break something in windows.
Put the Method definitions in an enum or proper class? As long as we can combine Methods together like this: GET | POST then this might work.
Don't include winnt.h in the project somehow?

AlexanderJDupree commented 4 years ago

I did #under DELETE in defs.h and that seems to fix the errors. However, this might break something further down the line so I'm going to leave the issue open for now.