search

AlexanderK88 / a4-uppgift-2-biograf-sajt

Arbetsmetodik och agila projektmetoder Uppgift 2 - en biograf-sajt
3 stars 1 forks source link

Build header #46

Closed AlexanderK88 closed 11 months ago

AlexanderK88 commented 11 months ago

I have successfully completed the header design for the desktop version. Additionally, I've implemented a maximum width constraint for the header to prevent it from endlessly stretching on exceptionally wide screens. The specified limit is set at 1200 pixels. Feel free to examine the outcomes in the images provided with this message.

Screenshot 2023-12-27 231047 Screenshot 2023-12-27 231055

AlexanderK88 commented 11 months ago

I think its good that youve provided an alt for the img since its essential for accessibility. I like how you've used BEM like we talked about and how you've nested the selectors in SCSS. The desktop version looks great but i thought we said that we should do mobile-first. Other then that, great work!

I initially focused on the desktop version, and my next task involves developing the mobile hamburger menu. The hamburger menu is designated as the default display, with the desktop version of the header appearing on larger screens. Once both versions are created, I will implement the code to toggle between the menus. I chose to start with the desktop version due to the limited time I had available today, so I opted for the menu element that required less time. Converting it to a mobile-first design involves just a minor code adjustment. However, my plan is when this pull request is merged to concentrate on the hamburger menu and ensure it becomes the default menu in the code. (create hamburger menu #7)