Sorry for missing this earlier (I kinda knew I missed it).
So actually, I think everything's perfectly good with this code. See this PR for an initial condition that's really a single soliton -- it evolves fine.
You did a nice job here (okay, I can always find some things, like have an orphan init_functions.cpp in addition to init_funcs.cpp, and I don't find what you did with near for the boundaries the prettiest solution, but it works. A nice report, too (other than the lack of LaTeX support in github), a youtube movie, the parallelization looks good, too (though as you saw, it doesn't really help).
Sorry for missing this earlier (I kinda knew I missed it).
So actually, I think everything's perfectly good with this code. See this PR for an initial condition that's really a single soliton -- it evolves fine.
You did a nice job here (okay, I can always find some things, like have an orphan
init_functions.cppin addition toinit_funcs.cpp, and I don't find what you did withnearfor the boundaries the prettiest solution, but it works. A nice report, too (other than the lack of LaTeX support in github), a youtube movie, the parallelization looks good, too (though as you saw, it doesn't really help).2.5/2