Open VictorioBerra opened 5 years ago
I have been attempting this, turns out I have bumped into an issue with the ToListAsync()
and CountAsync()
in EFCore and keeping net40
as target framework.
Honestly, I think we should drop support for net40 and only support netstandard. This is exactly the kind of problem netstandard is trying to solve.
Hi @VictorioBerra, thank you so much for the pull request! Unfortunately I can not approve this without additional changes. The are some reasons why:
I appreciate your contribution and will keep the pull as a starting point for further investigation.
Thanks a lot for looking at this I appreciate it. For now I think I can solve my immediate issue by doing my own paging so I'm the one calling ToListAsync and passing down the CancellationToken. It would be nice to see this implemented some day though.
-Tory
You could keep the ASPNET Core web port though. I may PR you some tests when I can get around to it.
ASPNET Core automatically wires up a CancellationToken in your controller actions, so it would be really helpful if we could add
ToListAsync()
to the paging stuff.We would put it here and pass it all the way up to the calling code https://github.com/AlexanderKrutov/DataTables.Queryable/blob/master/DataTables.Queryable/PagedList.cs#L78 and this way we could avoid doing
Task.Factory
stuff like here https://github.com/AlexanderKrutov/DataTables.Queryable/blob/master/DataTables.Queryable/QueryableExtensions.cs#L78