search

AlexanderMelde / dl_for_heise

Simple shell script to batch download heise magazine PDFs. You need to have access to the archive via a paid subscription to use this.
62 stars 9 forks source link

Please add single issue download #6

Open PoC-dev opened 8 months ago

PoC-dev commented 8 months ago

I've been searching for an automatic downloader for Heise magazines some years ago, but no avail. This changed. Thanks to you. :-)

I miss the feature to just get a single magazine, but fail to come up with a nice idea how to integrate this into the existing command line.

What do you think?

AlexanderMelde commented 8 months ago

Hello @PoC-dev, you're welcome!

To download just a single magazine one could remove the for-loop https://github.com/AlexanderMelde/dl_for_heise/blob/2e592419e5c0c9635c7e554428670f914559c92e/download.sh#L74-L76 and instead assign a value to the year and issue number variables directly (or pass them to the script as arguments).

If you want to make this change, I would suggest saving your modifications to a separate file download_issue.sh, as unfortunately I don't have a heise subscription currently and could not review your changes to the original script.

To reduce redundancy, integrating it into the existing script would definitely be a nicer solution, but I think given the current size of the project we can go this path for now. if you want to prepare the code for a later merge, you could encapsulate the whole functionality for downloading one issue into a function that can either be called via the for-loop or directly.

Best, Alexander