AlexanderOtavka / ride-board

Ride sharing for Grinnell students

https://rideboard.app

MIT License

1 stars 3 forks source link

Add user defined names #77

Closed YourFin closed 4 years ago

YourFin commented 4 years ago

Resolves #43

Changes

Needs to:

Add "name" field to database
Override display name if possible with new value
Add "name" field to relevant user forms

Manual Testing

Steps for the reviewer to go through in the review app (automatically deployed on heroku and > linked in the PR) to verify that the changes are correct. For example:

Go to page A and click button X

Go to page B and make sure it has feature Y

TBD

YourFin commented 4 years ago

I can refactor user_display name out if everyone wants, but I figured I'd do the easy thing that doesn't step on any toes by default

AlexanderOtavka commented 4 years ago

Looks like we are stepping on one another's toes a bit.