search

AlexanderOtavka / ride-board

Ride sharing for Grinnell students
https://rideboard.app
MIT License
1 stars 3 forks source link

Signup #96

Open lequytra opened 4 years ago

lequytra commented 4 years ago

Resolves #35

Changes

Manual Testing

  1. Sign up.
  2. Wait for the email :">
  3. Upon receiving the email, click on the "Confirm my account" link.
  4. Pray that it takes you to a page that lets you set your password.

Todo:

  1. Page to set passwords needs some UI work.
  2. Make it obvious to users that they can leave their password blank for now when signing up. (maybe hide the password field at first and have a button like "set my password" to make the password field pops up).
AlexanderOtavka commented 4 years ago

I'm putting the do not merge label on this because it looks like you still have some TODO items that you have set for yourself. Feel free to remove the label when you feel the PR is ready to merge.

AlexanderOtavka commented 4 years ago

Is this branched from the confirmation branch? Does it make sense to close #25 and merge from here instead to avoid dealing with merge conflicts?

AlexanderOtavka commented 4 years ago

Also, can we make authenticate_user! send them to the Sign Up page by default rather than Sign In?