search

AlexanderTanJunAn / pe

0 stars 0 forks source link

Phone number multiplicity #8

Open AlexanderTanJunAn opened 3 years ago

AlexanderTanJunAn commented 3 years ago

Screenshot 2021-04-16 at 5.23.51 PM.png

Based on the UG and program behaviour, phone number seems to be an optional parameter. In the DG however, the multiplicity is 1, should it be 0..1 instead?

nus-pe-bot commented 3 years ago

Team's Response

Even if no phone number is entered by the user, a Phone object is still created with a null value for only one of its attributes. So, there will always be a Phone object, and thus multiplicity is always 1.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While i understand where you are coming from, I believe it is good practice to instead put [0..1] due to the NULL value.

Screenshot 2021-04-22 at 11.33.17 AM.png

As you can see from the screenshot of the lecture notes, NULL is counted as 0.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: This should not be very low as it is not purely cosmetic. It should be low since it does not affect normal operations of the product but causes a minor inconvenience in rare situations.