search

AlexanderThaller / prometheus_exporter

Helper libary to export prometheus metrics using tiny_http and rust-prometheus.
MIT License
28 stars 10 forks source link

0.4 broken #1

Closed sengaya closed 4 years ago

sengaya commented 5 years ago

The 0.4 version does not return any data (empty site). The 0.3 version works as expected. Tested with both of the examples.

AlexanderThaller commented 4 years ago

Hello sengaya, I forgot to update the depenencies in the examples. They where using a different (older) version of the prometheus crate so the global registrar for metrics was different from the crate so no metrics where registered in a way the crate could see.

I updated the dependencies of the examples in commit https://github.com/AlexanderThaller/prometheus_exporter/commit/629dc5e8be096bc18afa078026b70fb54a73e42e which fixed it for me.

Hope that helped. Sorry about the confusion. Probably should make sure that I keep the dependencies in sync somehow.

AlexanderThaller commented 4 years ago

I also updated the readme to make it more clear that the rust-prometheus version needs to be in sync with the version of this crate.

Hope that resolves the issue for you. Thank you for making me aware of this.

sengaya commented 4 years ago

Thanks for the update and the explanation. Works as expected.