[BUG] Bool variable returning "183" or "76"

[AlexanderTonn]

:bug: Describe the bug

• Debugging Output for xTrigBatteryFull returning 183
• this fault leads to that the control logic is not exectued properly

 :bangbang: To Reproduce**

Steps to reproduce the behavior:

•  :white_check_mark: tried to reduce the Serial Output in main loop
•  :white_check_mark: tried to change the order of variable declaration
•  :white_check_mark: :heavy_exclamation_mark: if i backet out the sctMeasuring() function, the return value is getting xTrigBatteryFull=76

:interrobang: Expected behavior

• only 0 or 1 should returned

:camera: Screenshots

Serial monitor

:computer: Desktop (please complete the following information):**

• OS: macOS 13.4.1
• Arduino IDE
• Version 1.2.2

 :iphone: Smartphone (please complete the following information):**

Additional context

[AlexanderTonn]

I'm not clearly sure what the issue was, but i suppose that I did something wrong with the declaration and the including of the template function in "Util.h" and "util.ino".

[AlexanderTonn]

I had the same issue again with following Terminal Output:

  bool xTrigBatteryFull = edgeDetection(fBatteryVoltage, 
                                  fTrigBatteryFullPrevious, 
                                  edgeType::RISING_EDGE, 
                                  fTargetVoltageInverter);    // Battery is full after reaching 100%
  bool xTrigBatteryEmpty = edgeDetection(fBatteryVoltage, fTrigBatteryEmptyPrevious, edgeType::FALLING_EDGE, fTargetVoltageMppt); // Battery should charged if dropped down to 50%

  Serial.print("xTrigBatteryFull: ");
Serial.println(xTrigBatteryFull);
Serial.print("xTrigBatteryEmpty: ");
Serial.println(xTrigBatteryEmpty);

xTrigBatteryFull: 0
xTrigBatteryEmpty: 0

Reason for the issue

• i figured out that the edgeDetection() function is returning this values if no if-loop is passed. In this case the function would not return true or false and the value of the variable which is initialized with this function can be have any value
• i only have to play safe that i return false if i don't go into the if-else loops

template<typename T1, typename T2, typename T3 >
auto edgeDetection (T1 TinputSignal, T2 &TpreviousSignal, edgeType Type, T3 Ttrigger ) -> bool {
  // RISING EDGE detection
  switch(Type)
  {
    case edgeType::RISING_EDGE :
    if (TinputSignal >= Ttrigger && TpreviousSignal < Ttrigger ) {
      TpreviousSignal = TinputSignal;
      return true;
    }
    // Resetting the signal if Ttrigger was reached
    else if ((TinputSignal >= Ttrigger && TpreviousSignal >= Ttrigger) 
          || (TinputSignal < Ttrigger && TpreviousSignal >= Ttrigger)) {
      TpreviousSignal = TinputSignal;
      return false;
    }
+ else 
+      return false; 
    break;