AlexanderWillner / runMacOSinVirtualBox

Run macOS 10.16 Big Sur (and other versions) in VirtualBox on macOS
MIT License
936 stars 125 forks source link

applicationpath parameter is not needed with macOS 10.14 or better #122

Open paulschreiber opened 3 years ago

paulschreiber commented 3 years ago

To Reproduce Steps to reproduce the behavior:

  1. Put "Install macOS Mojave" in /Applications
  2. Run make all

Expected behavior No warnings

Actual behavior

WARNING: "--applicationpath" is deprecated in macOS 10.14 and greater. Please remove it from your invocation.

Additional context

[2020-12-07 10:03:09] Creating image '/Users/paul/VirtualBox VMs/macOS-VM.dmg' (takes a while, version 14.6.06, will need sudo)...
[2020-12-07 10:03:09] .
created: /Users/paul/VirtualBox VMs/macOS-VM.dmg

/dev/disk3              Apple_partition_scheme          
/dev/disk3s1            Apple_partition_map             
/dev/disk3s2            Apple_HFS                       /Volumes/macOS-VM
WARNING: "--applicationpath" is deprecated in macOS 10.14 and greater. Please remove it from your invocation.
Erasing disk: 0%... 10%...
 20%...
 30%... 100%
Copying to disk: 0%...
 10%...
 20%...
 30%...
 40%...
 100%
Making disk bootable...
Copying boot files...
Install media now available at "/Volumes/Install macOS Mojave"
"disk3" ejected.
AlexanderWillner commented 3 years ago

If the parameter is removed, the installation of macOS 10.13 and older wouldn't work. So having a warning (not an error) is fine imho. No?

paulschreiber commented 3 years ago

Can you detect which version of macOS you're installing and use it only when needed?