AlexanderYW / adonis-ally-azure-ad

MIT License
5 stars 4 forks source link

changed naming convention + updated package.json #6

Open tianjos opened 2 years ago

AlexanderYW commented 2 years ago

Hi @tianjos, Changing the naming convention seems like an overkill and will cause breaking changes for everyone depending on the package, therefor i cannot approve this pull request

I also don't understand why you're moving the types out of the types.d.ts files

If you can revoke all the changes you did except the "peerDependency" you added and the update to "files" in package.json then i'm more than happy to approve your changes