search

AlexanderZaytsev / react-native-i18n

React Native + i18n.js
MIT License
2.18k stars 493 forks source link

Android cannot build with minSdkVersion in AndroidManifest #301

Open olibooty opened 1 year ago

olibooty commented 1 year ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-i18n@2.0.15 for the project I'm working on.

I had a lint error while running a production build saying that minSdkVersion should be removed from AndroidManifest.xml and placed in build.gradle. As it was already in build.gradle, all I had to do was remove this line.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-i18n/android/src/main/AndroidManifest.xml b/node_modules/react-native-i18n/android/src/main/AndroidManifest.xml
index 818651f..3d228f4 100644
--- a/node_modules/react-native-i18n/android/src/main/AndroidManifest.xml
+++ b/node_modules/react-native-i18n/android/src/main/AndroidManifest.xml
@@ -1,5 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.AlexanderZaytsev.RNI18n">
-    <uses-sdk android:minSdkVersion="16" />
 </manifest>

This issue body was partially generated by patch-package.