AlexanderZaytsev / react-native-i18n

React Native + i18n.js
MIT License
2.18k stars 493 forks source link

Compile keyword does not exist in the new versions of Gradle #305

Open EsaNuurtamo opened 1 year ago

EsaNuurtamo commented 1 year ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-i18n@2.0.15 for the project I'm working on.

In newer version of gradle that is used in new react-native versions function compile name has been changed to implementation

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-i18n/android/build.gradle b/node_modules/react-native-i18n/android/build.gradle
index 2614c62..746b873 100644
--- a/node_modules/react-native-i18n/android/build.gradle
+++ b/node_modules/react-native-i18n/android/build.gradle
@@ -22,5 +22,5 @@ android {
 }

 dependencies {
-  compile "com.facebook.react:react-native:+" // From node_modules
+  implementation "com.facebook.react:react-native:+" // From node_modules
 }

This issue body was partially generated by patch-package.

HodeiG commented 1 year ago

Does the main README also need to be updated?

In file ./android/app/build.gradle, I had to modify this:

dependencies {
    // ...
    compile project(':react-native-i18n')
}

To this:

dependencies {
    // ...
    implementation project(':react-native-i18n')
}

p.d.: I am new to react-native development