search

AlexandrErohin / TP-Link-Archer-C6U

Python package for API access and management for TP-Link Routers. See supported routers list
GNU General Public License v3.0
31 stars 13 forks source link

Add IoT wifi support #4

Closed adamgross42 closed 5 months ago

adamgross42 commented 6 months ago

Enum values and README updates

I am surprised that this required the "guest" value on https://github.com/AlexandrErohin/TP-Link-Archer-C6U/blob/main/tplinkrouterc6u/client.py#L57 - but it seems to work still.

Tested with Archer AX3000.

adamgross42 commented 6 months ago

I'm not sure how to handle the situation where these IoT fields aren't supported on a device model - there may need to be None-checks in a few places.

adamgross42 commented 6 months ago

I attempted to rebase on the latest 'main' branch, duplicate commits may have to be squashed.

AlexandrErohin commented 6 months ago

@adamgross42 Thanks! Could you check my comment for making iot_2g_enable bool | None

adamgross42 commented 6 months ago

Hmm, I don't see any comments in this PR - maybe the review needs to be submitted for me to see them?

adamgross42 commented 5 months ago

@AlexandrErohin , what are your thoughts on this? Are you able to test this locally to confirm the null checks work for a router that doesn't have the IoT network?

AlexandrErohin commented 5 months ago

@adamgross42 Hi! Thank you for this PR. Unfortunately, I didnt have time to test it on my router. Give me a week please to check this.

AlexandrErohin commented 5 months ago

@adamgross42 I have released it https://pypi.org/project/tplinkrouterc6u/1.3.0/ Thank you!