Alexandra-Ivanova-P-41 / lw1

0 stars 0 forks source link

Замечания по lw1 #1

Open ivklgn opened 3 years ago

ivklgn commented 3 years ago

в веб-проектах всегда должен присутствовать index.html можно оформить: index.html index-dark-theme.html

ivklgn commented 3 years ago
Снимок экрана 2020-10-28 в 16 43 34

имя картинки Figma - не имеет смысла и не должно касать дизайн инструмента в котором разрабатывался макет. если есть картинка с логотипом, то нужно назвать logo.png или logo.jpg

картинки с именами 1,2,3... лучше обозвать image-1, image-2 (те которые в articles)

ivklgn commented 3 years ago
    <div class="header_content">
      <span class="line"></span>
      <p class="blog">BLOG</p>
      <p class="about">ABOUT</p>
      <p class="links">LINKS</p>
      <p class="projects">PROJECTS</p>
    </div>

здесь речь про навигацию, параграф использован неверно. создайте меню навигации с помощью menu/nav и понятными классами

используйте тег <a>link</a>

ivklgn commented 3 years ago
<div class="content">
    <span class="content_image"><img src="picture/2.png"></span>
    <span class="line3"></span>
    <p class="content_information">A few words about this blog platform, Ghost, and how this site was made</p>
    <p class="content_information-two">Why Ghost (& Figma) instead of Medium,</br> WordPress or other options?</p>
  </div>
  <div class="articles">
    <p class="articles_article">All articles</p>
    <span class="articles_image"><img src="picture/11.png"></span>
    <p class="articles_information">Here are some things you should know regarding how we work</p>
    <span class="articles_image1"><img src="picture/14.png"></span>
    <p class="articles_information1">Granny gives everyone the finger, and other tips from OFFF Barcelona</p>
    <span class="articles_image2"><img src="picture/16.png"></span>
    <p class="articles_information2">Hello world, or, in other words, why this blog exists</p>
    <span class="articles_image3"><img src="picture/12.png"></span>
    <p class="articles_information3">Here are some things you should know regarding how we work</p>
    <span class="articles_image4"><img src="picture/17.png"></span>
    <p class="articles_information4">Connecting artificial intelligence with digital product design</p>
    <span class="articles_image5"><img src="picture/18.png"></span>
    <p class="articles_information5">It’s all about finding the perfect balance</p>
    <span class="articles_image6"><img src="picture/13.png"></span>
    <p class="articles_information6">I believe learning is the most important skill</p>
    <span class="articles_image7"><img src="picture/15.png"></span>
    <p class="articles_information7">Clients are part of the team</p>
    <span class="articles_image8"><img src="picture/22.png"></span>
    <p class="articles_information8">Clients are part of the team</p>
    <span class="articles_image9"><img src="picture/20.png"></span>
    <p class="articles_information9">Here are some things you should know regarding how we work</p>
    <span class="articles_image10"><img src="picture/19.png"></span>
    <p class="articles_information10">Connecting artificial intelligence with digital product design</p>
    <span class="articles_image11"><img src="picture/21.png"></span>
    <p class="articles_information11">How modern remote working tools get along with Old School Cowboy's methods</p>
  </div>

используйте блочную верстку с помощью div или html5 теги наподобии article для блочных элементов

ivklgn commented 3 years ago

articles_information1, articles_information2, articles_information3 - классы об одном и тоже. у вас должен быть один класс для множества элементов

уберите дублирование стилей, не стоит копипастить бездумно фигму

ivklgn commented 3 years ago

picture -> images или img