Alexandre-io / homeassistant-vcontrol

Vcontrold Home Assistant add-on repository
Apache License 2.0
37 stars 23 forks source link

Set values are cut off too early #48

Open dk1305hb opened 10 months ago

dk1305hb commented 10 months ago

Hi,

I have noticed that some set commands are not successful if the values have got whitespaces.

Example from Unit "BetriebsArt", enum value <enum bytes="04" text="H+WW FS"/>

The set command is cut off after "H+WW"

I think the reason is in vcontrold/rootfs/etc/services.d/vclient_sub/run Line 19

echo "setBetriebsArt H+WW FS" | cut -d' ' -f2 =H+WW

Maybe solved by echo "setBetriebsArt H+WW FS" | cut -d' ' -f2- =H+WW FS

Regards Daniel

Huskerdu24 commented 9 months ago

I see a similar issue here: The payload for the heating shedule doesn’t work at all. I.e. this:

select: 
    - name: "HZ01 Timer HZ Mo Sel"
      unique_id: "vcontroldgetTimerMoHeizen"
      state_topic: "openv/getTimerMoHeizen"
      device:
        identifiers: vcontrold
        manufacturer: Viessmann
      command_topic: "openv/setTimerMoHeizen"
      options:
        - "Zeit 1"
        - "Zeit 2"
      command_template: |-
        {% if value == 'Zeit 1' %}
        06:30 08:30 18:30 22:00
        {% elif value == 'Zeit 2' %}
        07:30 10:30 19:30 23:30
        {% endif %}

Option "Zeit 1" sends only the first “on”-time in the string = “06:30”. It doesn’t send the whole String "06:30 08:30 18:30 22:00" including the other values. Hopefully there will be a solution for that at some point as well.

ppuetsch commented 9 months ago

I think the root cause is that in https://github.com/Alexandre-io/homeassistant-vcontrol/blob/main/vcontrold/rootfs/etc/services.d/vclient_sub/run the mosquito_sub messages are split by space. A workaround is maybe to format the output of mosquito_sub using the -F option (see https://mosquitto.org/man/mosquitto_sub-1.html).

Huskerdu24 commented 9 months ago

Thank you. I am not a programmer. Can I somehow solve the problem myself?